[MGNLUI-2804] Fix paddings in the bottom area of a regular dialog Created: 15/Apr/14  Updated: 15/Apr/16  Resolved: 15/Apr/16

Status: Closed
Project: Magnolia UI
Component/s: dialogs, forms
Affects Version/s: 5.2.4
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Andreas Weder Assignee: Unassigned
Resolution: Duplicate Votes: 0
Labels: design, next, quickwin, ux
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File 1 current - too crammed.png     PNG File 2 to change.png     PNG File 3 after change.png    
Issue Links:
duplicate
is duplicated by MGNLUI-3568 No or wrong bottom padding in dialogs Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

The footer of the dialog is currently too narrow: the buttons look very much crammed into it. Also, the distance between the last field in the form and the border separating dialog body and footer is too small, which doesn't make the dialog to appear generous enough.

Please do the following:

  • set the top and the bottom padding of the "dialog-footer" to 7px each (currently: 5px)
  • increase the bottom padding of the form to 40px. Make sure it remains 40px also when an error and/or help text appears.


 Comments   
Comment by Christopher Zimmermann [ 10/Jun/14 ]

When the browser is too small vertically and the dialog does not fit, then the bottom of the dialog (including half the buttons) is off the bottom of the browser.

The problem is the new padding on this element:
.dialog-content .v-shell-tabsheet-scroller

{ padding-bottom: 24px; }

It could be added instead to the inner wrapper:
.dialog-content .v-shell-tabsheet-scroller > div

{ padding-bottom: 24px; }
Comment by Mikaël Geljić [ 10/Jun/14 ]

Reverted temporarily due to height calculation + scrollbar issues for "plain" dialogs. Will have to be reconsidered when time allows.

Generated at Mon Feb 12 09:00:19 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.