[MGNLUI-2814] ENTER keyboard shortcut causes error in Move Dialog Created: 22/Apr/14  Updated: 13/May/14  Resolved: 30/Apr/14

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.2.4
Fix Version/s: 5.2.5

Type: Bug Priority: Major
Reporter: Christopher Zimmermann Assignee: Peili Liang
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLUI-2673 Support of ESC and ENTER in dialogs, ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

To reproduce:

  • Select an asset.
  • Click "Move asset" action.
    > Dialog opens.
  • Select a new location in the dialog.
  • Hit ENTER key.
    > Red error bar appears - in pulse is message "An error occurred while executing an action. No definition exists for action: commit."

However if you press the "MOVE INSIDE" button, the item is moved as expected.

The problem relates to the fact that the ENTER keyboard attempts to trigger the action named "commit" which most dialogs have. (See BaseDialogPresenter#CommitDialogShortcutListener).
Move dialog (see MoveDialogPresenterImpl) actually has three actions. The button that looks like the commit simply has a "commit" css class added to it.
The complexity is that the MOVE INSIDE is only applicable if a user has selected a directory. So what SHOULD happen if user hits ENTER? MOVE BEFORE action triggered?

Perhaps ENTER key should not be supported here.
Perhaps the code throwing the exception should check for "commit" action and skip the exeption in that case.

ERROR a.ui.contentapp.movedialog.MoveDialogPresenterImpl: An error occurred while executing an action.
info.magnolia.ui.api.action.ActionExecutionException: No definition exists for action: commit
at info.magnolia.ui.api.action.AbstractActionExecutor.createAction(AbstractActionExecutor.java:93)



 Comments   
Comment by Cheng Hu [ 29/Apr/14 ]

The behavior we implement for the ENTER key is that if the Move Inside button is available, it will be as if Move Inside button is pressed. If the Move Inside button is not available, then it will be as if nothing happened and there will be no errors.

Generated at Mon Feb 12 09:00:25 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.