[MGNLUI-2817] UI Tests for ESC and ENTER keyboard shortcuts in dialogs, detail editors and confirmations Created: 23/Apr/14  Updated: 08/May/14  Resolved: 06/May/14

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.2.5
Fix Version/s: 5.2.5

Type: Task Priority: Neutral
Reporter: Christopher Zimmermann Assignee: Christopher Zimmermann
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
is related to MGNLUI-2673 Support of ESC and ENTER in dialogs, ... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

Create UI tests for these shortcut keys.



 Comments   
Comment by Christopher Zimmermann [ 23/Apr/14 ]

Added new UI test class KeyboardShortcutUITest with several tests.

Comment by Daniel Lipp [ 24/Apr/14 ]

There's a bunch of issues here:

AbstractMagnoliaUITest

  • lowering DRIVER_WAIT_IN_SECONDS from 10 to 2 seconds will have impact on all UITests. It's a max value - in case elements can be found faster, they will. With the new value we might regularly run into ElementNotFoundExceptions in various tests. We shouldn't touch until it's intensely tested with all UI tests - locally and on jenkins
  • getElementByPath and other methods where javadoc has been adapted
  • tags like @path or @driver are not valid: tag for all params is @param

KeyboardShortcutUITest (minor)

  • Copyright should say 2014
  • looks like Keys.RETURN has to be used in order to simulate an "ENTER" - at many places (not all) this is commented by a "Note Keys.ENTER does not work."
    -> in order to be more DRY I'd just add that comment to the javadoc of the class so it's more obvious. Also it might be worth a short research and e.g. link to an explanation or a selenium bug that explains, why it doesn't work atm
Comment by Christopher Zimmermann [ 24/Apr/14 ]

Fixed bad delay value and javadoc in AbstractMagnoliaUITest.
Made a constant to clarify problems with Keys.ENTER in KeyboardShortcutUITest.

Comment by Daniel Lipp [ 28/Apr/14 ]

Needs to be ported to master!

Comment by Christopher Zimmermann [ 06/May/14 ]

Port latest fixes for tests on master back to 5.2

Generated at Mon Feb 12 09:00:27 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.