[MGNLUI-2840] (Potentially) long running actions should be configured to run asynchronously Created: 28/Apr/14 Updated: 06/Aug/15 Resolved: 23/May/14 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 5.2.4 |
| Fix Version/s: | 5.2.5 |
| Type: | Improvement | Priority: | Critical |
| Reporter: | Daniel Lipp | Assignee: | Jaroslav Simak |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||||||
| Description |
|
With
as both of the actions involve versioning of content and can be time consuming |
| Comments |
| Comment by Mikaël Geljić [ 09/May/14 ] |
|
Reverted on 5.3 — too many shortcomings for the user, activation statuses are no longer refreshed, deleted nodes still show up and only disappear after explicit tree view refresh. You should consider reverting on 5.2.x as well; async feature is in that's cool, but given the side-effects this has to be an explicit intentional setting, not the default. |
| Comment by Jan Haderka [ 11/May/14 ] |
|
@mika w/o the feature effect is even worse. If you start long running action, it will kill the UI completely as it becomes unresponsive completely until such action finishes, which in case of deletion of whole tree or activation including subnodes on reasonably big tree might mean few to tens of minutes. |
| Comment by Jaroslav Simak [ 15/May/14 ] |
|
Commits: |
| Comment by Jaroslav Simak [ 15/May/14 ] |
|
Forwardport to 5.3 will be part of integration. |
| Comment by Andreas Weder [ 15/May/14 ] |
|
Cool stuff. It looks and feels quite professional. This will have quite a positive impact on usability for the affected cases. I suggest the following wording. Notification sent when the action takes longer: Message appearing in Pulse: If you can say more about the item, e.g. "on the page '/demo-project'", that would even be better. I'm asking Antti to quickly review this. |
| Comment by Andreas Weder [ 16/May/14 ] |
|
If we have two error messages (because we can't and probably shouldn't get rid of the "scheduler error"), I think that's fine with me. Let's show a more general warning that the action has failed, and which refers to the logs and the Scheduler error for more info. Here's my suggestion after our discussion. 1. But we show the main portions of the stack trace in addition to that. Can we show it in a separate field in the message details shown when I double-click the message. So there, we would have then: 2. And then on the message details page: |
| Comment by Andreas Weder [ 16/May/14 ] |
|
The new screenshots look great. I realized that I proposed to use "additional" twice plus one time "addition" within the same message! Thus, please change the warning comment to this: |
| Comment by Antti Hietala [ 16/May/14 ] |
|
Language in the proposed messages is fine and can be implemented as such. Possible improvements:
Info: "Publish incl. subpages" completed successfully. [MORE] Sender: superuser |
| Comment by Daniel Lipp [ 21/May/14 ] |
|
Introduces a circular dependency to ui-framework |
| Comment by Andreas Weder [ 22/May/14 ] |
|
Ok, so for long-running actions triggered within workitems, I think we have to do some trickery. The concept for long-running actions is built for the new "tasks" tab in Pulse - for 5.2.x, this can't be applied. Here's the current flow without asynchronous activiation:
Here's my suggestion for the new flow with asynchronous activation:
Does that make sense? Can this be implemented? I actually wouldn't mind, if:
|
| Comment by Andreas Weder [ 22/May/14 ] |
|
As for the text of the mentioned Pulse messages for async actions triggered in workflow, here is my suggestion. (3.1.2)
(3.2.1) Info: Publication has completed successfully. [MORE] (3.2.2) Warning: Publication has failed. [MORE] Sender: superuser |
| Comment by Jaroslav Simak [ 23/May/14 ] |
|
Enabling of asynchronous actions and messages for workflow done in |