[MGNLUI-2853] Cleanup AvailabilityChecker, shorthand rules, tests Created: 02/May/14  Updated: 27/May/14  Resolved: 02/May/14

Status: Closed
Project: Magnolia UI
Component/s: content app
Affects Version/s: 5.3
Fix Version/s: 5.3

Type: Task Priority: Neutral
Reporter: Mikaël Geljić Assignee: Mikaël Geljić
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Cloners
clones MGNLUI-2778 Create tests for jcr-agnostic-content... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Epic Link: JCR-agnostic content apps
Sprint: 5.3 Sprint 5, 5.3 Sprint 6

 Description   

During QA of MGNLUI-2778, I found that some code in AvailabilityCheckerImpl, shorthand AvailabilityRules and AvailabilityCheckerTest can be cleaned up a bit, in particular:

  • Shorthand rule classes can be named more consistently
  • Constructors of such AvailabilityRules can be removed, especially those taking non-primitive types as param.
  • Simplify/streamline javadoc
  • AvailabilityCheckerTest should be renamed to -ImplTest, underscores in method names should be removed and dummy rules should be moved to nested classes.

Generated at Mon Feb 12 09:00:48 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.