[MGNLUI-2877] Can't move properties via action in Configuration app Created: 08/May/14  Updated: 16/May/14  Resolved: 11/May/14

Status: Closed
Project: Magnolia UI
Component/s: configuration, user interaction
Affects Version/s: None
Fix Version/s: 5.3

Type: Bug Priority: Critical
Reporter: Mikaël Geljić Assignee: Jan Haderka
Resolution: Fixed Votes: 0
Labels: usability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Build #3428 (16.09.2013 09:23:56)


Attachments: PNG File Bildschirmfoto 2013-09-16 um 11.15.27.png    
Issue Links:
Cloners
clones MGNLUI-2101 Can't move properties in Configuratio... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

Even though moving properties via DnD was implemented in MGNLUI-2101, the move action is still disabled for properties.
1. It misses properties: true under its availability node.
2. Furthermore, when availability is fixed, using the dialog doesn't work either: clicking "move inside" does indeed move properties and we get the notification "Item(s) moved.", but the move dialog doesn't close itself, and the tree is then not refreshed.



 Comments   
Comment by Jan Haderka [ 10/May/14 ]

2. Furthermore, when availability is fixed, using the dialog doesn't work either: clicking "move inside" does indeed move properties and we get the notification "Item(s) moved.", but the move dialog doesn't close itself, and the tree is then not refreshed.

Indeed. In the log following message appears when this happens:
WARNING: RPC call to info.magnolia.ui.vaadin.gwt.client.dialog.rpc.OverlayServerRpc.onClosed received for connector 128 but no such connector could be found. Resynchronizing client.
If you try to repeat the action, it will fail with NPE as selected item was actually moved. Could issue with synchronisation be caused by some other change? I don't remember ever having this issue during the development.

Comment by Aleksandr Pchelintcev [ 14/May/14 ]

Looks good, but there're couple of things to polish in MoveNodeAction:

  • JcrItemUtil.getItemId(nodeAdapter.getJcrItem()) can be simplified to nodeAdapter.getItemId()
  • Local variable nodeAdapter probably should be renamed to e.g. jcrItemAdapter as long as it doesn't represent only nodes exclusively.
Generated at Mon Feb 12 09:01:02 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.