[MGNLUI-2945] Action availability with writePermissionRequired does not work on root level Created: 28/May/14 Updated: 05/Dec/14 Resolved: 18/Aug/14 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | content app |
| Affects Version/s: | 5.2.4 |
| Fix Version/s: | 5.3.3 |
| Type: | Bug | Priority: | Major |
| Reporter: | Frank Sommer | Assignee: | Eric Hechinger |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | availability | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||||||
| Description |
|
If you restrict the access to actions with the writePermissionRequired flag, it will work except on root level (no item is selected). The 'Add ...' and 'Import' actions are always clickable. |
| Comments |
| Comment by Mikaël Geljić [ 10/Jul/14 ] |
|
Now is a good time to tackle that, hopefully it should be less of a hassle in 5.3. For 5.2 we'll have to check implications and consider it carefully. |
| Comment by Eric Hechinger [ 18/Aug/14 ] |
|
I removed the fixed version 5.2.9, as this would be quite impossible to solve for this version. |
| Comment by Mikaël Geljić [ 22/Aug/14 ] |
|
Review done. In particular, each rule was kept as dry as possible, i.e. only the root (default item) availability rule is aware of the default itemId. However there was a couple shortcomings to work around still:
Current workaround is that whenever default item is selected and root availability is true, we dismiss nodes/nodeTypes rules because we want root availability to prevail upon these. |