[MGNLUI-2978] Missing tab label for detail subapp Created: 06/Jun/14 Updated: 19/Jun/14 Resolved: 12/Jun/14 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.3 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Milan Divilek | Assignee: | Christopher Zimmermann |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Description |
|
See attached screenshot. This happens for all detail subapps (pages app, asset app, contact app, inplace-templating, ...), but not for all entry. For example in pages app - "subsection-articles" page has title every time, but "article" page never. It happens for entries which have space in title, but only when they are open from browser app directly. If page without space in title is opened then tab label is available and then if you navigate (in same instance of detail subapp) to the page with space in title then label is correctly shown. |
| Comments |
| Comment by Christopher Zimmermann [ 10/Jun/14 ] |
|
I could not reproduce this on the CI build. How can i reproduce this? |
| Comment by Christopher Zimmermann [ 10/Jun/14 ] |
|
Milan writes: |
| Comment by Christopher Zimmermann [ 12/Jun/14 ] |
|
Simplified dom structure of MagnoliaTabLabel to something Safari can handle. In FormViewImpl focus first field in tab so that the tab does not stay focussed which looked wierd on a click. Tested on Safari/Chrome/Firefox/iPad Safari/ie9 |
| Comment by Christoph Meier [ 12/Jun/14 ] |
|
review: |
| Comment by Christopher Zimmermann [ 12/Jun/14 ] |
|
Removed bad comment. |