[MGNLUI-2993] Pressing enter in search text field should trigger search in Chooser Dialogs Created: 11/Jun/14 Updated: 05/Dec/14 Resolved: 27/Aug/14 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.2.9, 5.3.3 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Boris Kraft | Assignee: | Chunhua Liu |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | next, quickwin, support, usability, ux | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
Open a chooser dialog (e.g. Page Chooser, Asset Chooser), enter a string into the search text field and press <enter> Workaround:
|
| Comments |
| Comment by Chunhua Liu [ 14/Aug/14 ] |
|
Please review code on branch |
| Comment by Mikaël Geljić [ 18/Aug/14 ] |
|
Filtering keyboard shortcuts should not be the responsibility of a field — in other words, extending the TextField component should not be necessary. We would opt for a Vaadin Extension (see the TextAreaStretcher for an example). Please feel free to ask if you need additional input/support on this. Side note: admittedly, the Panel-based approach that we generally use to 'scope' keyboard shortcuts doesn't work here; we would have nested panels and the parent would always be triggered no matter what. |
| Comment by Chunhua Liu [ 27/Aug/14 ] |
|
Implemented solution using Vaadin extension.
|
| Comment by Mikaël Geljić [ 29/Aug/14 ] |
|
Much nicer
I will now mark the ticket as reviewed, squash those commits and integrate it. Final note: by the way the event handling was actually good as is. |