[MGNLUI-3018] Fix generic types for the CompositeFieldFactory Created: 19/Jun/14 Updated: 19/Jun/14 Resolved: 19/Jun/14 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | forms |
| Affects Version/s: | 5.3 |
| Fix Version/s: | 5.3 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Mikaël Geljić | Assignee: | Mikaël Geljić |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Description |
|
Currently hard codes generic type to CompositeFieldDefinition in constructor, so it cannot be extended, and does not expose such definition typing correctly to subclasses (declares "new" standalone generic type extending FieldDefinition). Additionally, would be good to use interface type for FieldDefinition in AbstractCustomMultiField#createLocalField(...), so that we don't have to cast in subclasses without a reason to. |