[MGNLUI-3032] Consolidate the UI against NPEs Created: 30/Jun/14  Updated: 02/Jul/14  Resolved: 30/Jun/14

Status: Closed
Project: Magnolia UI
Component/s: framework
Affects Version/s: 5.3
Fix Version/s: 5.3.1

Type: Bug Priority: Major
Reporter: Mikaël Geljić Assignee: Mikaël Geljić
Resolution: Fixed Votes: 0
Labels: quickwin
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLUI-2945 Action availability with writePermiss... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

During development of my conference demo, I faced a series of UI issues, most of them related to using null as defaultItemId in the ContentConnector.

Most of the fixes actually go in two directions:

  • preventing NPEs with null checks
  • null must never be added to the list of selected items

Here's the complete list:

  • NPE in WorkbenchPresenter if contentConnector's defaultItemId is null
  • NPE in AbstractContentPresenterBase if contentConnector's defaultItemId is null
  • No visible section in action bar if defaultItemId is null
  • Dialog actions are not available if dialog operates on a simple item (i.e. not a JCR adapter)
    • FormDialogPresenterImpl#filterActions should be restrictive, not additive
  • NPE when checking availability if no action matches defined name in action bar (BrowserSubApp)

Generated at Mon Feb 12 09:02:33 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.