[MGNLUI-305] Applied input form CodeReview to JcrPropertyAdapter Created: 03/Dec/12  Updated: 11/Feb/13  Resolved: 05/Dec/12

Status: Closed
Project: Magnolia UI
Component/s: content app
Affects Version/s: 5.0
Fix Version/s: 5.0

Type: Task Priority: Major
Reporter: Daniel Lipp Assignee: Mikaël Geljić
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
caused by MGNLUI-195 implement JcrPropertyAdapter updating... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Date of First Response:

 Description   

MGNLUI-195 has not been reviewed within s009. So this review should happen in s010.



 Comments   
Comment by Daniel Lipp [ 03/Dec/12 ]

Design issue: does it really make sense to have removed + changed properties on AbstractJcrItemAdapter - how and when does JcrPropertyAdapter use them?
Exception handling: don't error-log AND re-throw Exceptions - choose one option (e.g. line 194, 195)

VCS: we should use commit messages consisting of several sentences as in 939e9a235f5c223f0ff665384cdcc2f5a19cb77f

Comment by Tobias Mattsson [ 03/Dec/12 ]
  • AbstractJcrAdapter
    • javadoc should use form {@link x}
    • UN_IDENTIFIED should be one word
  • AbstractJcrNodeAdapter
    • use term identifier or nodeIdentifier instead of uuid
  • JcrPropertyAdapter
    • VALUE_COLUMN and TYPE_COLUMN, isn't necessarily always columns right? would VALUE_PROPERTY and TYPE_PROPERTY not be better?
Comment by Mikaël Geljić [ 05/Dec/12 ]

Pushed changes.

As discussed already, the map of changed properties in AbstractJcrAdapter is a map of vaadin properties (DefaultProperty), which may change as well for JCR property adapters (say the property is being renamed, or its value changes).

Just generalized this behavior which was preexisting for node adapters, that such maps are first populated (e.g. on valueChange) and that these changes are processed right before saving. Currently, JcrNodeAdapter does it implicitly when calling getNode(), JcrPropertyAdapter does it explicitly when calling updateProperties().

This will be streamlined in the next iteration of work on JCR adapters, with broader focus than in MGNLUI-195.

Generated at Mon Feb 12 08:35:35 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.