[MGNLUI-3066] Add value change listener on UploadField in order to propagate the changes on file name field Created: 16/Jul/14  Updated: 05/Dec/14  Resolved: 22/Jul/14

Status: Closed
Project: Magnolia UI
Component/s: forms
Affects Version/s: 5.3.1
Fix Version/s: 5.3.2

Type: Bug Priority: Neutral
Reporter: Eric Hechinger Assignee: Eric Hechinger
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
causality
is causing MGNLDAM-484 Cannot change an asset's file name Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

UploadField need to propagate changes done in the file name field.



 Comments   
Comment by Daniel Lipp [ 21/Jul/14 ]

Bunch of minor issues:

UploadReceiverTest

  • testGetFileNameInvalid + testSetFileName
  • no added value to check for non-null (assertNotNull) then compare with a non-null value
    -> drop the obsolete null check
  • testGetFileNameInvalid
    -> bad name (not clear what’s meant)

BasicUploadField

  • is there a name clash on ValueChangeEvent? Can’t we import that package and just use the type name in the ValueChangeListener?

UploadReceiver#receiveUpload(String, String)

  • should call setFileName(String) rather then directly access the attribute

Remark:

  • be sure to nicely squash and enhance commit messages before merging to real branch
  • commit messages like “adapt text class and correct code based on the review” are not understandable by anyone not having participated at the review
Generated at Mon Feb 12 09:02:53 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.