[MGNLUI-3124] SaveUserDialogAction should process sub-nodes (e.g. uploaded image), not only properties. Created: 27/Aug/14  Updated: 05/Dec/14  Resolved: 27/Oct/14

Status: Closed
Project: Magnolia UI
Component/s: forms, security app
Affects Version/s: 5.2.8, 5.3.2
Fix Version/s: 5.3.5

Type: Improvement Priority: Neutral
Reporter: Christian Ringele Assignee: Aleksandr Pchelintcev
Resolution: Fixed Votes: 1
Labels: support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: Text File AbstractJcrNodeAdapter.patch     Text File SaveUserDialog.patch    
Issue Links:
Relates
relates to MGNLSTK-1426 STKTemplatingFunctions: Provide funct... Closed
causality
Template:
Patch included:
Yes
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

Use Case:
Adding an image to the user dialog in security app.

Problem:
info.magnolia.security.app.dialog.action.SaveUserDialogAction
As JcrNodeAdapter#applyChanges() is not called, the AbstractJcrNodeAdapter#updateChildren(Node) is also never called
=> no dialog field value will be stored which creates a subnode instead of a property (example: DamUploadFieldDefinition).



 Comments   
Comment by Mikaël Geljić [ 03/Oct/14 ]

Hang. On.

I remember discussing it with @Eric, SaveUserDialogAction is indeed a specific case — if not the only one — because it does not call #applyChanges().
It only wants to process properties and protect some of them against changes; I'd rather be interested to see if we can do this protection upfront while still invoking #applyChanges then.

Generated at Mon Feb 12 09:03:26 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.