[MGNLUI-3128] FormBuilder: defaultLocale in dialogs is always taken from the "default" site definiton Created: 28/Aug/14 Updated: 05/Dec/14 Resolved: 30/Sep/14 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | dialogs, forms, framework |
| Affects Version/s: | 5.3.2 |
| Fix Version/s: | 5.3.4 |
| Type: | Bug | Priority: | Major |
| Reporter: | Christian Ringele | Assignee: | Philip Mundt |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | support | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||||||||||||||
| Description |
|
When opening an edit dialog in page app, defaultLocale is taken from the default site and not from node-based I18NAuthoringSupport. Additionally, the DefaultI18NAuthoringSupport.i18nize(...) method wrongly uses the fallbackLocale to add a suffix to i18nizable properties. It should instead use the defaultLocale. Possible solution:
Both solutions have in common:
NotesThe described behavior was also detected on the defaultLocale ( |
| Comments |
| Comment by Christian Ringele [ 28/Aug/14 ] |
|
follow up |
| Comment by Evzen Fochr [ 25/Sep/14 ] |
|
To work correctly |
| Comment by Mikaël Geljić [ 26/Sep/14 ] |
|
| Comment by Evzen Fochr [ 29/Sep/14 ] |
|
ExtendedI18NAuthoringSupport.java is a workaround preventing circling dependency between framework and dialog. |
| Comment by Mikaël Geljić [ 30/Sep/14 ] |
|
Good point, we can't cast to DefaultI18nAuthoringSupport there :# Let's see if that's the way to go. |
| Comment by Mikaël Geljić [ 30/Sep/14 ] |
|
Alright, looking again at i18nization vs. forms: there are fishy things in code that have been here for months, and we'd like to prevent adding more on top.
For now we're still checking how to proceed on this one / what is reasonable to do now. |