[MGNLUI-3164] Enable freemarker highlighting in code fields Created: 02/Sep/14 Updated: 05/Dec/14 Resolved: 23/Sep/14 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.3.4 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Christian Ringele | Assignee: | Aleksandr Pchelintcev |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | support | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
||||||||||||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Date of First Response: | |||||||||||||
| Description |
|
The freemarker code is not highlitghted anymore in the inplace templating module. The reason is, that the vaadin library in use for the form field: |
| Comments |
| Comment by Aleksandr Pchelintcev [ 21/Sep/14 ] |
|
Fixed the issue by making several compromises:
|
| Comment by Christopher Zimmermann [ 22/Sep/14 ] |
|
Please update the javadoc on BasicTextCodeFieldFactory#checkModeType. Im noticing that in Resources module now many of the files have little warning icons which display messages when you roll over them. I think this may be introduced by this change and they should be disabled - all of the ones that I saw were not helpful because they didnt really understand the context of the code or css. This might be helpful: http://japhr.blogspot.ch/2013/06/setting-jshint-options-in-ace-from-dart.html |
| Comment by Christopher Zimmermann [ 25/Sep/14 ] |
|
Two minor things: Fix typo in javadoc for that method |