[MGNLUI-3258] When deleting groups/roles dependencies have to be removed manually Created: 17/Nov/14  Updated: 06/Aug/15  Resolved: 27/Jul/15

Status: Closed
Project: Magnolia UI
Component/s: security app
Affects Version/s: 5.3.5
Fix Version/s: 5.3.11, 5.4.1

Type: Improvement Priority: Major
Reporter: Lars Fischer Assignee: Evzen Fochr
Resolution: Fixed Votes: 0
Labels: groups, roles, support, usability, uzh
Remaining Estimate: 0d
Time Spent: 2d 2h 5m
Original Estimate: Not Specified

Attachments: PNG File GroupFolderDeletionFailed.png     PNG File Screen Shot 2015-07-21 at 17.54.44.png    
Issue Links:
Relates
relates to MGNLUI-3286 Deleting folder of groups or roles do... Closed
dependency
depends upon MGNLUI-3276 Deleting groups or roles is too slow ... Closed
depends upon MAGNOLIA-6287 Expose remove function in MgnlGroupMa... Closed
is depended upon by MAGNOLIA-6300 Adjust SecurityAppUiTest to changes i... Closed
relation
is related to MGNLUI-3493 SecurityApp DeleteGroup and DeleteRol... Open
is related to MGNLUI-3093 Improve UI for deleting folders, grou... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Sprint: Sprint 2 (Basel)
Story Points: 2

 Description   

When deleting groups/roles dependencies have to be removed manually.

That means: A group/role cannot have assigned groups/persons before it can be deleted.

When having a large amount of users/groups it can be practically impossible (ot at least be very tedious) to remove all existing dependencies manually.

It must be possible to delete a group/role automatically considering existing dependencies (interactive dialog with force remove).



 Comments   
Comment by Federico Grilli [ 26/Nov/14 ]

Deleting groups and roles dependencies from a large user base may cause a performance problem. Let's put this issue on hold until the one we depend upon is solved, which should improve performance for operations on the user workspace.

Comment by Aleksandr Pchelintcev [ 20/Jul/15 ]
  • pls make sure the dependency list presented in confirmation dialog is clear, i.e. in case of multi-selection - it states which node depends on what.
  • getAssignedRolesAndGroupList method has to be renamed cause it really looks for groups and users, not roles.
Comment by Aleksandr Pchelintcev [ 21/Jul/15 ]

i18n:

  • adapt all the related message files to the changes (still refs to the old actions in non-eng files)

dialog:

  • The message of the dialog doesn't seem to be entirely correct
    • "This action cannot be undone" comes before the list of deps. Pls also add this statement to the end.

impl:

  • Since the dep list message construction became more complex - maybe it makes sense to extract method from #execute()?
    • also when compiling a list of deps for a node - use method argument if possible instead of playing with action's current node
  • While you're at it - confirmation dialog opening could also be extracted into a method (if that would make things clearer)

tests:

  • Pls remove that custom sub-app context class and replace it with Mockito#doAnswer().
Comment by Philip Mundt [ 27/Jul/15 ]

Solution introduces a migration diff (see Diff-Report config.modules.security-app.html (46 lines changed)):

Comment by Evzen Fochr [ 27/Jul/15 ]

Missing update task to remove confirmDeleteFolder, confirmDeleteRole and confirmDeleteGroup actions.

Generated at Mon Feb 12 09:04:48 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.