[MGNLUI-3290] Field properties: Combination of i18n=true & readOnly=true results in Exception & Dialog or subApp does not open. Created: 10/Dec/14  Updated: 06/Aug/15  Resolved: 13/Jan/15

Status: Closed
Project: Magnolia UI
Component/s: forms
Affects Version/s: 5.3.5
Fix Version/s: 5.3.7

Type: Bug Priority: Neutral
Reporter: Christian Ringele Assignee: Evzen Fochr
Resolution: Fixed Votes: 0
Labels: support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File Form-readOnly-ContactsApp.png     PNG File Form-readOnly-TextImageDialog.png    
Issue Links:
duplicate
is duplicated by MGNLUI-3291 MGNLUI-3290 Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Visible to:
Sanel Mesinovic

 Description   

The combination of these two properties on a form field does not work:

  • i18n = true
  • readOnly = true

The the detail subapp of the contacts app does not open and trows:

2014-12-10 09:49:48,033 ERROR agnolia.ui.framework.app.AppInstanceControllerImpl: Sub-app detail failed to start: Invocation of method valueChange in info.magnolia.ui.dialog.formdialog.ItemFormView$2 failed.
com.vaadin.event.ListenerMethod$MethodException: Invocation of method valueChange in info.magnolia.ui.dialog.formdialog.ItemFormView$2 failed.
	at com.vaadin.event.ListenerMethod.receiveEvent(ListenerMethod.java:528)
	at com.vaadin.event.EventRouter.fireEvent(EventRouter.java:167)
	at com.vaadin.server.AbstractClientConnector.fireEvent(AbstractClientConnector.java:969)
	at com.vaadin.ui.AbstractField.fireValueChange(AbstractField.java:1126)
	at com.vaadin.ui.AbstractField.setValue(AbstractField.java:542)
	at com.vaadin.ui.AbstractSelect.setValue(AbstractSelect.java:702)
	at com.vaadin.ui.AbstractSelect.setValue(AbstractSelect.java:671)
	at info.magnolia.ui.dialog.formdialog.ItemFormView.setCurrentLocale(ItemFormView.java:143)
	at info.magnolia.ui.dialog.formdialog.FormBuilder.buildForm(FormBuilder.java:132)
	at info.magnolia.ui.contentapp.detail.DetailPresenter.setItemView(DetailPresenter.java:159)
	at info.magnolia.ui.contentapp.detail.DetailPresenter.start(DetailPresenter.java:138)
	at info.magnolia.ui.contentapp.detail.DetailEditorPresenter.start(DetailEditorPresenter.java:122)
	at info.magnolia.ui.contentapp.detail.DetailEditorPresenter.start(DetailEditorPresenter.java:101)
	at info.magnolia.ui.contentapp.detail.DetailSubApp.start(DetailSubApp.java:118)
	at info.magnolia.ui.contentapp.detail.DetailSubApp.start(DetailSubApp.java:1)

In the textImage component the dialog does not open and trwos:

2014-12-10 09:51:04,699 ERROR info.magnolia.pages.app.editor.PageEditorPresenter: An error occurred while executing action [editComponent]
info.magnolia.ui.api.action.ActionExecutionException: Action execution failed for action: editComponent
	at info.magnolia.ui.api.action.AbstractActionExecutor.execute(AbstractActionExecutor.java:64)
	at info.magnolia.pages.app.editor.PageEditorPresenter.onAction(PageEditorPresenter.java:127)
	at info.magnolia.ui.vaadin.editor.PageEditor$1.editComponent(PageEditor.java:93)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at com.vaadin.server.ServerRpcManager.applyInvocation(ServerRpcManager.java:168)
	at com.vaadin.server.ServerRpcManager.applyInvocation(ServerRpcManager.java:118)
	at com.vaadin.server.communication.ServerRpcHandler.handleBurst(ServerRpcHandler.java:214)
	at com.vaadin.server.communication.ServerRpcHandler.handleRpc(ServerRpcHandler.java:111)
	at com.vaadin.server.communication.UidlRequestHandler.synchronizedHandleRequest(UidlRequestHandler.java:91)
	at com.vaadin.server.SynchronizedRequestHandler.handleRequest(SynchronizedRequestHandler.java:37)
	at com.vaadin.server.VaadinService.handleRequest(VaadinService.java:1371)
	at com.vaadin.server.VaadinServlet.service(VaadinServlet.java:238)


 Comments   
Comment by Aleksandr Pchelintcev [ 13/Jan/15 ]
  • The additions to BasicTransformer and invocation of its writeToItem method are not necessary - we only need to update the TransformedProperty value, which can be achieved by calling the super.setValue().
  • Casting to a concrete transformer type within a TransformedProperty should be avoided.
Comment by YMC AG [ 13/Jan/15 ]

Hello,

Actually it is YMC AG who raised the issue with Christian Ringele.

The issue is closed now. Is there a patch or will this fix be available from which Magnolia version ?

Thanks

Comment by Evzen Fochr [ 19/Jan/15 ]

Fix version for this ticket is set to 5.3.7 and it should be released at the end of January.

Generated at Mon Feb 12 09:05:07 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.