[MGNLUI-3307] Inconsistent behavior for selecting delete and publish deletion actions Created: 19/Dec/14  Updated: 06/Aug/15  Resolved: 16/Jun/15

Status: Closed
Project: Magnolia UI
Component/s: pages app
Affects Version/s: 5.3.6
Fix Version/s: 5.3.10

Type: Bug Priority: Neutral
Reporter: Lars Fischer Assignee: Trang Truong
Resolution: Fixed Votes: 0
Labels: pages, support, uzh
Remaining Estimate: 1d
Time Spent: 6d
Original Estimate: 1h

Issue Links:
causality
is causing PAGES-19 Inconsistent behavior for selecting d... Closed
is causing MGNLWORKFLOW-293 Support multiple selection items for ... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

It' possible to select multiple pages in the pages app and select the action "delete" but it's not possible to have mulitple deleted pages selected and execute the action "publish deletion".

This behavior is considered inconsistent.



 Comments   
Comment by Trang Truong [ 10/Apr/15 ]

This issue is fixed by adding new constructor mapping with addition of List<? extends item> to ActivationAction class.

Besides, enable multiple property in config node for publishDeletion.

It affects to active action because of using workflow, if user enable multiple for active action, it will work too.

Comment by Espen Jervidalo [ 30/Apr/15 ]

ActivationActionTest#testPublishMultiDeletedItems
The test does not test the execution of the action (action.execute()). It only checks whether the items are assigned to the field in the class. These AbstractCommandAction's are not very easy testable, but there are some examples, for example the info.magnolia.ui.framework.action.DeleteActionTest .
Update: I just saw that you provided a UI-Test for this ticket. So in my opinion you can remove that test case.

Try to use assertThat together with Node and Property matchers. Just cosmetics.
PagesModuleVersionHandlerTest#updateFrom538UpdateAvailabilityRule

Make sure the changes are applied to master and 5.3.x

Comment by Michael Mühlebach [ 15/Jun/15 ]

Tests should modify/delete only data it owns itself aka. created itself.
The nodes which are deleted should be created first otherwise other test which rely on these will brake.

Comment by Philip Mundt [ 15/Jun/15 ]

Ignored the test until above is implemented (i.e. creation of page that should be deleted).

Comment by Trang Truong [ 16/Jun/15 ]

Its fixed by creation of page that should be deleted

Comment by Philip Mundt [ 18/Jun/15 ]

Very difficult to get this to test: the branch still uses 5.3.9-SNAPSHOT, however the change in UI is currently available on 5.3.10-SNAPSHOT.
Fix works!

Comment by Trang Truong [ 18/Jun/15 ]

Sorry for this inconvenient, I've tested it locally and put it to the fixed-issue branch before. It's remarked to update new version next time.

Generated at Mon Feb 12 09:05:18 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.