[MGNLUI-3360] Can't delete page if parent page is not activated Created: 24/Feb/15  Updated: 10/Jul/15  Resolved: 22/Apr/15

Status: Closed
Project: Magnolia UI
Component/s: pages app
Affects Version/s: 5.3.7
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Diana Racho Assignee: Trang Truong
Resolution: Obsolete Votes: 0
Labels: support
Remaining Estimate: 0d
Time Spent: 3d 1h
Original Estimate: 5h

Attachments: JPEG File can't delete page.jpg    
Issue Links:
supersession
is superseded by MGNLWORKFLOW-296 Can't delete page if parent page is n... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Visible to:
Frank Sommer

 Description   

"Publish deletion" action is disabled if parent page is not activated.



 Comments   
Comment by Trang Truong [ 07/Apr/15 ]

This issue caused by extending IsPublishableRule from active action which disable actions if all ancestors haven't activated.
So the solution to fix it is creating new IsPublishableRule content node with a property extends = override in /activateDeletion/availability/rules/ to prevent that rule.

Comment by Eric Hechinger [ 08/Apr/15 ]

For clarity:
in config.modules.pages.apps.pages.xml
please checkout the master version, and only add your new availability node at the correct place.

This will avoid to have 100 changes due to new node identifiers

 1523 	  	            <sv:value>929c097b-e521-4068-ab09-66ad7b35f072</sv:value>
  	1555 	            <sv:value>aa020d2e-afc0-42d0-b385-0129392b7bd9</sv:value>
  • This one is not cosmetic
    Please remove your duplicate update task. that is located twice in 5.3.8 and 5.3.9...
Comment by Trang Truong [ 13/Apr/15 ]

Thanks @Sasha for your detailed comments. The reason why I've added a new rule for IsPublishabeRule is to override the rule checking parent has to activated in activate action.

In my approach, we can add new rules to activate to apply for both actions (activate, activateDeletion) later on.

After got your ideas, I will change the approach to small changes in availability/rules that add new property extends=override to ignore rules in inheritance node.

Comment by Trang Truong [ 16/Apr/15 ]

Moved extends=override in "Add" action to "activateDeletion" action.

Comment by Aleksandr Pchelintcev [ 20/Apr/15 ]

Re-opening because:

  • The extends:override property is added to the base pages bootstrap file (CE-bundle). However, it is only needed by the EE version with workflow installed, which actually makes the activateDeletion action to extend activate action.
  • So I propose a corresponding (http://tinyurl.com/pg252fd) bootstrap file to be modified, so that the additional properties only show up when they are really required.
  • Also wouldn't a simple unit test cover the case better than the UI test? You can easily simulate the required page hierarchy and then test the rules against the availabilityChecker or directly?
  • Feel free to contact me or Espen (since he knows most about both workflow and pages) for the details.
Comment by Trang Truong [ 21/Apr/15 ]

Moved to MGNLWORKFLOW-296.

Generated at Mon Feb 12 09:05:50 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.