[MGNLUI-3386] ChooseDialog Actions don't support availability Created: 24/Mar/15  Updated: 06/Aug/15  Resolved: 21/Apr/15

Status: Closed
Project: Magnolia UI
Component/s: dialogs
Affects Version/s: 5.3.7
Fix Version/s: 5.3.9

Type: Bug Priority: Major
Reporter: Richard Unger Assignee: Trang Truong
Resolution: Fixed Votes: 4
Labels: choosedialog, support, ui
Remaining Estimate: 0d
Time Spent: 1.5d
Original Estimate: 3h

Attachments: Text File mgnl_3386_fixrenderer.patch    
Issue Links:
causality
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

The actions defined for ChooseDialogs don't support availability configuration.

This leads to the situations (for example):

  • editors can choose any node when picking content, ie they can pick folders when they should be picking images, etc...
  • editors can initiate an upload even though they don't have write permission in the selected folder, resulting in an exception

Please change this:
1) ChooseDialog actions should support availability rules just like regular actions in the actionBar.
2) IMHO the action buttons should not disappear, but rather just be disabled, otherwise I think the user will be confused.



 Comments   
Comment by Trang Truong [ 02/Apr/15 ]

Its fixed by adding new AvailabilityActionRenderer to handle button status.

Comment by Trang Truong [ 21/Apr/15 ]

This fix is including a private test method "testAddAvailabilityActionRenderer()" to check exist of a new renderer "commit" in list of action-renderers of ChooseDialogDefinition which instance inside of ContentAppDescriptor and can't get any return values from void method "openChooseDialog()".

Generated at Mon Feb 12 09:06:06 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.