[MGNLUI-3412] Admincentral crashes if app descriptor is invalid Created: 08/May/15  Updated: 04/Jan/16  Resolved: 11/May/15

Status: Closed
Project: Magnolia UI
Component/s: app framework, applauncher
Affects Version/s: 5.4
Fix Version/s: 5.4

Type: Bug Priority: Major
Reporter: Mikaël Geljić Assignee: Mikaël Geljić
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
supersession
is superseded by MGNLUI-3380 App launcher layout reloading mechani... Accepted
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled

 Description   

Calls DefinitionProvider.get() too eagerly:

  • first, AppDescriptorRegistry tries to get the descriptor to fire AppRegistryEvent with; but only the app name is used. We can surely live firing the event with the related DefinitionMetadata instead.
  • second, AppLauncherLayoutManagerImpl#getLayoutForCurrentUser() iterates over groups and apps, doesn't check if provider is valid before adding it.

Side note for future plans:

  • we should most likely remove the AppLauncherLayoutManager altogether and move the "current user layout" logic to the shell app (and spare one useless event "conversion" too).
  • RegistryEvents would probably make sense on the AbstractRegistry level now.

Generated at Mon Feb 12 09:06:21 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.