[MGNLUI-3427] Parent item may be null when executing OpenCreateDialogAction Created: 19/Dec/14 Updated: 06/Aug/15 Resolved: 02/Jun/15 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | framework |
| Affects Version/s: | None |
| Fix Version/s: | 5.3.9 |
| Type: | Bug | Priority: | Major |
| Reporter: | Lars Fischer | Assignee: | Federico Grilli |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | choosedialog, support, uzh | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Date of First Response: |
| Description |
|
To reproduce use STK Text and Image component. An exception is thrown when no folder is selected before clicking "upload & edit". See attached screenshots. |
| Comments |
| Comment by Federico Grilli [ 11/Feb/15 ] |
|
Apparently this has been fixed at least since dam 2.0.7 (Magnolia 5.3.7) as I cannot reproduce it. |
| Comment by Lars Fischer [ 03/Mar/15 ] |
|
Client checked and found that it still doesn't work. What I found: Now the buttons on the left "Upload..." only are selectable when no asset is selected or a folder (which is wrong too). |
| Comment by Frank Sommer [ 23/Apr/15 ] |
|
If you clear the dam link field in dialog before opening the choose dialog, the error will be occure. Reproduced with M5.3.7. Caused by: java.lang.NullPointerException
at info.magnolia.ui.vaadin.integration.contentconnector.JcrContentConnector.getNewItemId(JcrContentConnector.java:200)
at info.magnolia.ui.framework.action.OpenCreateDialogAction.execute(OpenCreateDialogAction.java:88)
at info.magnolia.ui.api.action.AbstractActionExecutor.execute(AbstractActionExecutor.java:62)
... 129 more
|
| Comment by Mikaël Geljić [ 21/May/15 ] |
|
| Comment by Federico Grilli [ 21/May/15 ] |
|
1) I agree, you mean something like this https://gist.github.com/anonymous/bb7b5849a985d800dea7 ? |
| Comment by Federico Grilli [ 26/May/15 ] |
|
See |
| Comment by Mikaël Geljić [ 28/May/15 ] |
|
@fgrilli |
| Comment by Aleksandr Pchelintcev [ 28/May/15 ] |
|
I think the test could be improved:
Also test doesn't need JavaDoc which anyway doesn't explain much. |