[MGNLUI-3429] User wrongly gets success notification when a SchedulerException occurs in async action Created: 18/May/15  Updated: 11/Aug/15  Resolved: 31/Jul/15

Status: Closed
Project: Magnolia UI
Component/s: framework
Affects Version/s: 5.3.8
Fix Version/s: 5.4.1

Type: Bug Priority: Neutral
Reporter: Mikaël Geljić Assignee: Ilgun Ilgun
Resolution: Fixed Votes: 0
Labels: async, asynch-issue
Remaining Estimate: 0d
Time Spent: 5h
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLUI-3510 Clean up async action execution Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Sprint 5 (Basel)
Story Points: 1

 Description   

In AbstractCommandAction we don't deal with potential SchedulerExceptions, which are typically left uncaught, as they occur in another thread.

This happens e.g. if the scheduler cannot instantiate the CommandJob (missing parameter candidate)

As a result, the job is not executing at the time the action checks for it, and considers it done and successful.



 Comments   
Comment by Ilgun Ilgun [ 30/Jun/15 ]

Changes can be found in: fix/MGNLUI-3429-SchedulerException-handling

Comment by Federico Grilli [ 27/Jul/15 ]
  • There's still a couple of {{// TODO broken contract ... }} in AbstractCommandAction.java, not sure if they were left intentionally in spite of resolving the issue or if they were overlooked.
  • Is there a particular reason why we use System.out and System.err instead of logging at triggerFired and triggerMisfired?
Comment by Espen Jervidalo [ 30/Jul/15 ]

Please see the linked ticket. We need to sync the integration and move all the scheduler related stuff into the new class.

Comment by Ilgun Ilgun [ 31/Jul/15 ]

Reworked due to changes in related ticket.

Comment by Ilgun Ilgun [ 07/Aug/15 ]

Latest version can be found at {{ fix/MGNLUI-3429-SchedulerException-handling-rebasedVersion }}

Generated at Mon Feb 12 09:06:31 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.