[MGNLUI-3430] Hide indeterminate progress bar upon previewing a page Created: 18/May/15  Updated: 24/Aug/15  Resolved: 21/Aug/15

Status: Closed
Project: Magnolia UI
Component/s: pages app
Affects Version/s: None
Fix Version/s: 5.3.11

Type: Bug Priority: Neutral
Reporter: Zdenek Skodik Assignee: Federico Grilli
Resolution: Fixed Votes: 0
Labels: support
Remaining Estimate: 0d
Time Spent: 1d
Original Estimate: Not Specified

Issue Links:
Relates
relation
is related to PAGES-10 Loading indicator in page editor prev... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Sprint 6 (Basel)
Story Points: 3

 Description   

If your page is short enough, like the hello world one from documentation, detail subapp keeps rendering a circular wheel although the page was rendered correctly. This might be quite confusing for users.



 Comments   
Comment by Mikaël Geljić [ 20/Aug/15 ]
  • PageEditorPreviewWrapper is server-side. Setting styleName from there (i.e. in the Vaadin world), to silently remove it on the client later is prone to inconsistencies. Vaadin will still be aware of that class in its current UI state; who knows, updating the UI could theoretically add it again.
  • Besides, doing it there also adds the v-csslayout-iframe-preview-loading-indicator class, which eventually confused the UI test (xpath checking for contains on the class attr)
    => I think it's more consistent to add that class from the client-side too, e.g. from the GWT PageEditorViewImpl, much closer to where this class is eventually removed later on (might have to be conditional whether we're in preview mode or not, but we should know).
  • Avoid using isExisting in UI test when you specifically expect the element *NOT* to be around anymore.
    Initial getElementByXPath() will run into the driver's fluent wait of 10s, before conceding this is a NonExistingWebElement.
    Use a waitUntil + ExpectedCondition instead. The one provided by #elementIsGone(xpath) should do the trick here.

Generated at Mon Feb 12 09:06:32 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.