[MGNLUI-3463] ComponentProvider is not removed from Components after tests Created: 18/Jun/15 Updated: 16/Mar/21 Resolved: 16/Mar/21 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | testing |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Milan Divilek | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | qa, testing | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Template: |
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Description |
|
info.magnolia.ui.framework.app.AppEventTest and info.magnolia.ui.framework.app.AppControllerImplTest set instance of info.magnolia.objectfactory.guice.GuiceComponentProvider into info.magnolia.objectfactory.Components, but the GuiceComponentProvider is not properly removed after test. This affects following tests which then uses the instance of GuiceComponentProvider from preceding test. And this can cause failing test. See https://jenkins.magnolia-cms.com/job/magnolia_ui/3489/ I fix the build by calling info.magnolia.test.ComponentsTestUtil#clear, but this fix problem only for following tests which use info.magnolia.test.ComponentsTestUtil - https://git.magnolia-cms.com/gitweb/?p=magnolia_ui.git;a=commit;h=edebc5315075bab3c226aca9cbfb4a883988d184 |