[MGNLUI-3473] Provide additional transformers alike the MultiValueSubChildrenNodeTransformer and MultiValueSubChildNodeTransformer for "multiselect fields" Created: 25/Jun/15 Updated: 03/Aug/15 Resolved: 23/Jul/15 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | forms |
| Affects Version/s: | 5.3.9 |
| Fix Version/s: | None |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Christian Ringele | Assignee: | Christoph Meier |
| Resolution: | Won't Fix | Votes: | 0 |
| Labels: | support | ||
| Remaining Estimate: | 2d | ||
| Time Spent: | 1d | ||
| Original Estimate: | 3d | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Date of First Response: | |||||||||
| Sprint: | Sprint 2 (Vietnam) | ||||||||
| Story Points: | 8 | ||||||||
| Description |
|
The TwinColumnField (actually a ComboBox) stores the data by default into a JCR MultiValue property. There is also the need for TwinColumnField to have this data stored different, into sub nodes etc as the DelegatingMultiValueFieldTransformer and DelegatingMultiValueSubnodeTransformer for the MultiField does. But the two Tramsformers DelegatingMultiValueFieldTransformer and DelegatingMultiValueSubnodeTransformer of the MultiField won't work for the TwinColumnField:
Caused by: com.vaadin.data.util.converter.Converter$ConversionException: Unable to convert value of type com.vaadin.data.util.PropertysetItem to presentation type interface java.util.Set. No converter is set and the types are not compatible.
Finally triggered, by a Type missmatch as the MultiField operates on Type PropertysetItem and the TwinColumn on a Set (LinkedHashSet in the end), in: setConverter(newDataSource.getType()); Creating a custom Transform for this is not an easy task, the customer gave up because its too time intensive. |
| Comments |
| Comment by Christoph Meier [ 22/Jul/15 ] |
|
See screenshots for the data structures we want to achieve with the new transformers.
for (2) and (3) we need new transformers. |
| Comment by Christoph Meier [ 23/Jul/15 ] |
|
See latest comment. |
| Comment by Christian Ringele [ 23/Jul/15 ] |
It is know, the same as we provide it for the MultiValue field. So its no custom transformer needed. Just one that can do the same as we already provide.
So if the customer would not be nice and have his ticket because he (and support) gave up after time loss, then it would have more relevance? MultiValue field saves per default a mutli value property MultiValue field provides transformers for saving into a series of properties or sub nodes. Saying that the MultiVaule field needs them, and we provide them, but on the TwinColumn it would be "creating them on stocks" becuase its a "Custom" case is strange. We provide two MultiValue fields, one can save different, the other not, why? |