[MGNLUI-3492] Add Action for yaml export in Configuration App. Created: 17/Jul/15  Updated: 14/Jan/16  Resolved: 22/Jul/15

Status: Closed
Project: Magnolia UI
Component/s: configuration
Affects Version/s: 5.4
Fix Version/s: 5.4.1

Type: Improvement Priority: Major
Reporter: Ilgun Ilgun Assignee: Ilgun Ilgun
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 2d 4.5h
Original Estimate: Not Specified

Issue Links:
relation
is related to MAGNOLIA-6306 Ability to export YAML files based on... Closed
is related to MGNLUI-3742 Backport ExportAction from 5.4.x to 5... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Epic Link: Config by file / code
Sprint: Sprint 2 (Basel)
Story Points: 2

 Description   

Adding an action to Configuration App in order to export JCR to YAML.



 Comments   
Comment by Aleksandr Pchelintcev [ 20/Jul/15 ]

MVH:

  • You have to install the new action via AdmincentralModuleVersionHandler for the previous versions (and add an MVH test)

IsDefinitionRule:

  • #isRegistryPresent
    • name doesn't reflect what the method does
    • second argument should be removed - it reveals the workaround for missing functionality (pls refer a ticket as well)
Comment by Aleksandr Pchelintcev [ 21/Jul/15 ]

MVH:

  • Pls remove formatting changes

MVH test:

  • updateTo541ExportToYaml - please rename to updateFrom54JcrToYamlExport or smth ("from" paradigm is important)
    • rationale - w/ test named "updateFrom<version>" - it never becomes obsolete, w/ "updateTo<version>" it becomes obsolete as soon as the version is increased.

IsDefinitionRule:

  • Not exactly what I was proposing

Misc:

  • IsDefinitionRule lacks a file header.
  • Dunno exactly (I'm no linguist) but I'd use just the word "export" instead of "exportation".
Comment by Aleksandr Pchelintcev [ 22/Jul/15 ]

Re-opened because:

  • Why the file downloading functionality was moved to AbstractCommandAction?
    • Not all of the commands and command actions are related to file operations.
    • If it was needed to extract that - you could create another abstract class as a base for file-exporting commands.
Generated at Mon Feb 12 09:07:09 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.