[MGNLUI-3516] DialogMigrationTask does not properly migrate tabs with extends property and some override items Created: 07/Aug/15 Updated: 15/Apr/16 Resolved: 16/Sep/15 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 5.3.10 |
| Fix Version/s: | 5.3.11, 5.4.3 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Viet Nguyen | Assignee: | Sang Ngo Huu |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | affect-vn-project | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 1d 5.5h | ||
| Original Estimate: | 1d | ||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Sprint: | Basel 10 | ||||||||
| Story Points: | 2 | ||||||||
| Description |
|
| Comments |
| Comment by Viet Nguyen [ 07/Aug/15 ] |
|
| Comment by Viet Nguyen [ 07/Aug/15 ] |
|
| Comment by Viet Nguyen [ 10/Aug/15 ] |
|
| Comment by Philip Mundt [ 14/Sep/15 ] |
|
| Comment by Philip Mundt [ 15/Sep/15 ] |
|
Provided solution still creates an empty node fields even when there are no custom fields in a tab definition (when using just extends). Simple fix would have been a check whether controls.hasNext() before actually creating the fields node in info.magnolia.ui.dialog.setup.DialogMigrationTask#handleTab()! Added fix and test on branch (including fresh rebase) |
| Comment by Roman Kovařík [ 16/Sep/15 ] |
|
Reopened: empty fields nodes should be removed from bootstrap files in STK, see https://jenkins.magnolia-cms.com/view/Migration/job/int_migration-tests_4.5-to-5.4.x-branch/Diff_Reports/. This ticket can be switched back to Integrated when a follow up ticket in STK will be created. |
| Comment by Philip Mundt [ 16/Sep/15 ] |
|
Re-resolved by fixing |