[MGNLUI-3526] Keyboard shortcuts interfere with Groovy console Created: 17/Aug/15 Updated: 15/Apr/16 Resolved: 21/Aug/15 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | widgets |
| Affects Version/s: | 5.4.1 |
| Fix Version/s: | 5.4.2 |
| Type: | Bug | Priority: | Major |
| Reporter: | Federico Grilli | Assignee: | Federico Grilli |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | regression | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 0.5d | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Sprint: | Sprint 6 (Basel) | ||||||||
| Story Points: | 3 | ||||||||
| Description |
|
To reproduce it |
| Comments |
| Comment by Mikaël Geljić [ 20/Aug/15 ] |
|
Relying on app/subapp id through regex check seems a bit silly to me, if the console is not in focus, shortcuts should work regardless of location. Using 0-9 shortcuts to cycle through apps would be "interrupted" when coming to the groovy console. I wasn't too fond of the original workaround either, but it seemed less resistant somehow, and I don't see any rational explanation why the focus hack we had no longer works, can't we adjust the terminal connector if needed? |
| Comment by Federico Grilli [ 20/Aug/15 ] |
|
Not sure if I get your point but the check is used precisely to skip shortcuts when the groovy console is in use. We want to avoid that typing, say 3, in the console, brings up the Favorites shell app. It also seems to be more robust than the one based on the focus hack. As I said in the description I tried all possible (known to me) tricks to keep the focus on the console (both on the server and client side) but nothing seemed to work reliably. I also tried fiddling with terminal connector w/o luck. Given the time it was invested on this (also considering the previous ticket) I wouldn't invest more time on this. |
| Comment by Mikaël Geljić [ 20/Aug/15 ] |
|
Sounds more like a fallback if we have no other option, I'd still favor a focus-based approach. |
| Comment by Zak Greant [ 24/Aug/15 ] |
|
Thanks folks! |