[MGNLUI-3530] Edit property dialog doesn't persist type (when using Long or Boolean) Created: 20/Aug/15  Updated: 07/Dec/21  Resolved: 07/Dec/21

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.4, 5.4.1
Fix Version/s: None

Type: Bug Priority: Major
Reporter: Mathias Conradt Assignee: Unassigned
Resolution: Obsolete Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

5.4 CE


Attachments: PNG File boolean1.PNG     PNG File boolean2.PNG    
Issue Links:
supersession
is superseded by MGNLUI-6439 Cannot set new property type Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: Migrate JCR Browser

 Description   

It's not possible edit properties with another type than String using the dialog, because the site configuration admin UI does not allow to change a property node type to Boolean or Long, it always remains String, even after editing it.

Property dialog - changing type to Boolean:

But it remains a String:

Workaround

Instead of using the dialog, double-click on the column and edit the value there.



 Comments   
Comment by Philip Mundt [ 21/Aug/15 ]

Hi, thanks for reporting this issue.

I can confirm that changing the type in the dialog is not working!

However, there is another, easier workaround: simply double-click on the column's value "String" and type in "Boolean".

On the other side, it doesn't make a difference whether the boolean property is actually stored as String (and not as Boolean). Node2Bean will still be able to set the appropriate property to true and thus enabling the locale. It is important that you have set the additional locale in the right place, depending on your version (CE vs. EE).

I will move this issue to magnolia_ui and rephrase it, if you don't mind.

Comment by Philip Mundt [ 21/Aug/15 ]

Adding new LocaleDefinitions to your instance should be done this way:

  1. You do not have site module installed (CE, non-default bundle):
    • Add the locale definition to /server/i18n/content/locales
  2. You have site module installed (CE):
    • Add the locale definition to your site definition at /modules/site/config/site/i18n/locales
  3. You have multisite installed (EE Pro):
    • Add the locale definition to your site definition at /modules/multisite/config/sites/<sitename>/i18n/locales

Edit: use correct path for site module's site config.

Comment by Mathias Conradt [ 21/Aug/15 ]

Thanks for the info. Good to know regarding the other workaround.
(btw: I don't have multisite installed, working with CE).

Comment by Mathias Conradt [ 21/Aug/15 ]

Just a note:

On the other side, it doesn't make a difference whether the boolean property is actually stored as String (and not as Boolean). Node2Bean will still be able to set the appropriate property to true and thus enabling the locale.

This did not work for me. Until the property wasn't Boolean, the additional language (I wanted to add French) was not available in the workspace / language dropdown. I tried restarting Tomcat as well, no difference. I had added it in: /modules/site/config/site/i18n/locales/ (on CE).

Comment by Philip Mundt [ 24/Aug/15 ]

Unfortunately, I cannot reproduce the issue. I've added an additional locale to the site def (using String enabled=true) and it appears on the website without restarting. The only thing I had to restart was the pages app in order for it to display the new locale.

Generated at Mon Feb 12 09:07:32 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.