[MGNLUI-3539] Favorites: After opening a bookmark in favorites, most clicks don't react anymore Created: 31/Aug/15 Updated: 25/May/18 Resolved: 29/Dec/15 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | favorites |
| Affects Version/s: | 5.4, 5.4.1 |
| Fix Version/s: | 5.4.4 |
| Type: | Bug | Priority: | Critical |
| Reporter: | Christian Ringele | Assignee: | Federico Grilli |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 6h 10m | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||||||
| Sprint: | Basel 19, Basel 24 | ||||||||||||||||||||||||||||
| Story Points: | 5 | ||||||||||||||||||||||||||||
| Description |
|
Reproduce: Create a link in Favorites. Then try to use it again, or close an app.
|
| Comments |
| Comment by Sven Bach [ 24/Sep/15 ] |
|
Any news on this? Seems not to be a browser issue. Not affects 5.3.6 / 5.3.8 Figured out that the LocationChangedEvent of AdmincentralEventBus is not fired. Feel free to ask for more information. |
| Comment by Philip Mundt [ 21/Dec/15 ] |
|
The changes on the ctor of info.magnolia.ui.admincentral.shellapp.favorites.FavoritesPresenter break binary compatibility. |
| Comment by Mikaël Geljić [ 21/Dec/15 ] |
|
While QAing |
| Comment by Federico Grilli [ 21/Dec/15 ] |
|
Hmm, the only change I made was to use LocationController instead of replacing the location with Vaadin's page object. How could such a despicable thing happen because of that change? :/ |
| Comment by Mikaël Geljić [ 22/Dec/15 ] |
|
Reopening anyhow, it's at least worth investigating, although unfortunate. :/ If it takes longer to hunt down, I will agree to proceed and fix later, since this bug here was far more critical anyway. |
| Comment by Mikaël Geljić [ 22/Dec/15 ] |
|
The more I think about it, the more I doubt using LocationController is a good fit for now—preloader has to be kicked in by client-side, *before* sending request to sync location back with server.
Right, a bit convoluted, but was working till 5.4. |
| Comment by Federico Grilli [ 29/Dec/15 ] |
|
mgeljic indeed it looks like this stopped working due to this change in Vaadin's Page https://dev.vaadin.com/ticket/12925. That occurred in version 7.2, which would explain why the issue doesn't show up in Magnolia 5.3.x (using Vaadin 7.1.x). One way to have the transition back would be to use the implementation below where we use directly Page.open(..) and pass null instead of "_self" as windowName parameter. This will "somehow" trigger again the FragmentChangedEvent which is handled at info.magnolia.ui.api.location.new FragmentChangedHandler() and which in turn apparently triggers the transition magic
@Override
public void goToLocation(final String location) {
final String completeLocation = getCompleteURIFromFragment(location);
Page.getCurrent().open(completeLocation, null, false);
}
|
| Comment by Mikaël Geljić [ 29/Dec/15 ] |
|
Thanks fgrilli! Sounds good to me, as long as we leave a comment (since it's not well documented on Page#open).
|
| Comment by Mikaël Geljić [ 29/Dec/15 ] |
|
Well, I ended up trying it out briefly:
I'm happy to go with this work-around for now, although I have the suspicion that we do not handle fragment changes correctly—#setUriFragment should work. Let's save this for later. |
| Comment by Federico Grilli [ 29/Dec/15 ] |
|
Hmm okay, I actually used #setUriFragment() and seemed to work fine... |
| Comment by Mikaël Geljić [ 29/Dec/15 ] |
|
iirc it doesn't re-sync selection properly |
| Comment by Nils Breunese [ 11/Jan/16 ] |
|
Is |
| Comment by Federico Grilli [ 11/Jan/16 ] |
|
Seems not to be related to this issue. I could reproduce |
| Comment by Nils Breunese [ 11/Jan/16 ] |
|
Hm, sadly favorites still won't be very useful for editors then, but thanks for checking. |
| Comment by Federico Grilli [ 12/Jan/16 ] |
|
Np, that's unfortunate indeed and hopefully will be tackled asap. |