[MGNLUI-3542] Temp files are not deleted after use of upload field Created: 25/Aug/15  Updated: 16/Nov/15  Resolved: 16/Sep/15

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.3.x, 5.4
Fix Version/s: 5.3.11, 5.4.3

Type: Bug Priority: Major
Reporter: Milan Divilek Assignee: AntonĂ­n Juran
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 1h
Original Estimate: Not Specified

Issue Links:
Cloners
is cloned by MGNLUI-3635 Restore and deprecate BasicUploadFiel... Closed
Relates
relates to MGNLDAM-619 Temp files are not deleted after usin... Closed
causality
is causing MGNLUI-3647 CleanTempFilesCommand can not handle ... Closed
dependency
relation
is related to MAGNOLIA-3688 Import files are not deleted after im... Closed
is related to MAGNOLIA-1502 Temp files are not cleaned up after f... Closed
is related to MGNLUI-3556 Admincentral-scoped event handlers ge... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Kromeriz 10
Story Points: 5

 Description   

During the import temporary import files are created in <webapp>/tmp directory, but they are not deleted after import.



 Comments   
Comment by Milan Divilek [ 14/Sep/15 ]

Ropen:
1. in info.magnolia.ui.form.field.factory.BasicUploadFieldFactory check if "field.getValue().getFile()" is not null
2. Updates should be registered for version 5.4.3, 5.4.2 was already released
3. info.magnolia.ui.framework.command.CleanTempFilesCommandTest formating
4. use Matchers instead of "assertFalse(session.getNode("/modules/ui-framework/commands/default/cleanTempFiles").hasProperty("class"));" in "info.magnolia.ui.framework.setup.UiFrameworkModuleVersionHandlerTest#updateFrom541DoNotConfigureCleanTempFilesCommandIfExists"
5. Merge UiFrameworkModuleVersionHandlerTest#updateFrom541ConfigureCleanTempFilesCommandIfDoesNotExist with UiFrameworkModuleVersionHandlerTest#updateFrom541DoNotConfigureCleanTempFilesJobIfSchedulerModuleIsNotInstalled
6. info.magnolia.ui.framework.setup.UiFrameworkModuleVersionHandlerTest#updateFrom541DoNotConfigureCleanTempFilesJobIfSchedulerModuleIsInstalledButCleanTempFilesCommandAlreadyExistsWithAnotherValueOfClassProperty is wrong in method name you are saying "IfSchedulerModuleIsInstalled", but it's not registered. Please also merge with UiFrameworkModuleVersionHandlerTest#updateFrom541DoNotConfigureCleanTempFilesCommandIfExists

Comment by Milan Divilek [ 16/Sep/15 ]

Reopen: On magnolia-ui-5.3.x branch scheduler job cleanTempFiles (config.modules.scheduler.config.jobs.cleanTempFiles.xml) has property enabled, but it should be active because MGNLSCH-36 was not backported to scheduler 2.1.x which is used with M5.3.x

Comment by AntonĂ­n Juran [ 16/Sep/15 ]

Fixed on MGNLUI-3542_5.3.11 branch.

Generated at Mon Feb 12 09:07:39 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.