[MGNLUI-3568] No or wrong bottom padding in dialogs Created: 09/Sep/15 Updated: 09/Feb/17 Resolved: 29/Jun/16 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | design, dialogs, forms |
| Affects Version/s: | 5.4.1, 5.4.2 |
| Fix Version/s: | 5.4.8, 5.5 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Andreas Weder | Assignee: | Hieu Nguyen Duc |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | next, quickwin, ux, visual-design | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 4d 3.75h | ||
| Original Estimate: | 3d | ||
| Attachments: |
|
||||||||||||||||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Sprint: | Saigon 51 | ||||||||||||||||
| Story Points: | 3 | ||||||||||||||||
| Description |
|
The padding between the last field and the bottom edge of the form should be 40px. There's currently no or not enough bottom padding after the last form field in a dialog. As a result, dialogs look unbalanced. After fix:
|
| Comments |
| Comment by Mikaël Geljić [ 15/Apr/16 ] |
|
Closed
|
| Comment by Mikaël Geljić [ 20/Jun/16 ] |
|
The ElementResizeListener for dynamic dialog height is in the following class: info.magnolia.ui.vaadin.gwt.client.dialog.connector.DialogContainingFormConnector |
| Comment by Hieu Nguyen Duc [ 27/Jun/16 ] |
|
mgeljic Do we just fix "the padding between the last field and the bottom edge of the form" or also fix "the top and the bottom padding of the "dialog-footer" to 7px each" (in the closed ticket). I'm not sure because this ticket just mentions the first one. |
| Comment by Andreas Weder [ 27/Jun/16 ] |
|
hieu.nguyen This issue is mostly about the padding between the last field and bottom edge of the dialog. If you find that that the dialog footer (which contains the buttons) is off as well, I suggest you either re-open that closed ticket or create a follow-up ticket that describes the issue. It's probably best to keep the two things separate. Thanks! |
| Comment by Mikaël Geljić [ 27/Jun/16 ] |
|
Thx guys for your patience while this was pending for review on my side. It seems there is currently a bottom-offset problem with detail subapps too, but not related to this change (I just filed |
| Comment by Hieu Nguyen Duc [ 01/Jul/16 ] |
|
QA failed because the bottom padding is just 36px. In fact, there would be still some issues if we resolved the above problem:
I think the scrolling issue |