[MGNLUI-3602] info.magnolia.dam.app.ui.field.definition.DamUploadFieldDefinition is not i18n aware Created: 23/Sep/15  Updated: 29/Sep/22  Resolved: 25/Jan/17

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.4.10, 5.5
Fix Version/s: 5.4.11, 5.5.2

Type: Bug Priority: Neutral
Reporter: Jan Schulte Assignee: Oanh Thai Hoang
Resolution: Fixed Votes: 4
Labels: None
Remaining Estimate: 0d
Time Spent: 3d 1.5h
Original Estimate: 3d

Issue Links:
Relates
relates to MAGNOLIA-6957 I18nNodeWrapper no longer wraps child... Closed
relates to MGNLUI-3879 i18n suffixes wrong for default local... Closed
causality
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: I18n fields issues
Sprint: Saigon 79, Saigon 80
Story Points: 5

 Description   

The info.magnolia.dam.app.ui.field.definition.DamUploadFieldDefinition is not i18n enabled
https://documentation.magnolia-cms.com/display/DOCS/DAM+upload+field
This is reproducable on our demoauthor instance.
If I insert the value "true" for i18n parameter (i18n: true) the binary information (binaryData, extension, filename…) is always saved on same node (binaryNodeName: import). In oldest version (Magnolia 5.3.x) the information was saved on a different node: binaryNodeName + language; ex. import_en
form:
tabs:
name: tabUpload
label: Upload
fields:
name: upload
class: info.magnolia.dam.app.ui.field.definition.DamUploadFieldDefinition
label: Upload asset
binaryNodeName: import
i18n: true
editFileName: true



 Comments   
Comment by Oanh Thai Hoang [ 17/Jan/17 ]

Hi viet.nguyen. Since I can't make i18n work on DamUploadFieldDefinition even in version 5.3.4. I looked deeply into source code and it's history, I found that we don't support i18n for this field before. Could you please ask our client for more detail how can he make it work in (Magnolia 5.3.x). It would help me a lot. Thank you

Comment by Tom Wespi [ 13/Feb/17 ]

I tested with 5.4.11 and it seems that it still doesn't work.

I tested with 2 languages (de/en), created an i18n file upload field, uploaded 2 files (test_de.pdf, test_en.pdf) and created a link to them with cmsfn.link(content.file).

It creates following, wrong link:
/test/main/0/test_de.pdf
/en/test/main/0/test_de.pdf

The files are saved correctly under the node
/test/main/0/file/filename ...
/test/main/0/file_en/filename ...

Comment by Mikaël Geljić [ 13/Feb/17 ]

Hi tomwespi, first thanks for mentioning the storage did work as it should!
A bit of shame we still didn't quite cover the whole story; I filed MAGNOLIA-6957 for addressing this issue.

Thanks again for reporting,

Generated at Mon Feb 12 09:08:16 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.