[MGNLUI-3626] Deprecate hack for multiple selection availability in actionbar sections Created: 15/Oct/15  Updated: 15/Apr/16  Resolved: 19/Oct/15

Status: Closed
Project: Magnolia UI
Component/s: actionbar
Affects Version/s: None
Fix Version/s: 5.4.3

Type: Task Priority: Neutral
Reporter: Mikaël Geljić Assignee: Mikaël Geljić
Resolution: Fixed Votes: 0
Labels: actionbar, availability
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLRES-222 Adjust the title of the Action bar de... Closed
relates to MGNLUI-3096 Section availability for multiple sel... Closed
relates to MGNLUI-3585 Action bar is not well structured whe... Closed
causality
caused by MGNLUI-1991 Cleanup Actionbar dependencies and ap... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Sprint: Basel 15
Story Points: 1

 Description   

We should remove the hack in ConfiguredActionbarSectionDefinition#setAvailability, always setting section availability for multiple selection to true.

In effect, we cannot simply remove it because most—if not all—content-apps are misconfigured.
The multiple property is never configured, for sections intended for multi-selection.
So multi-selection would result in an empty action bar.

Besides, as quirky as this is, we don't want to change behavior that could potentially affect apps for existing customers.

  1. We fix the UI def, extend it with a deprecated one (with the hack), and register it as default type-mapping.
    • This way, the hack moves to a deprecated class, and we can eventually phase it out at some point in the future.
  2. We don't try to address potential usages in apps, not much worth the pain. Instead, action bar config may be re-evaluated (different ticket).

See https://wiki.magnolia-cms.com/display/WIKI/Options+for+solving+multiple+actionbar+availability for details.



 Comments   
Comment by Mikaël Geljić [ 19/Oct/15 ]

Actually, I just found out that "hybrid" selection of items with different type is broken (same symptom: blank actionbar, most likely ever since 5.3). Only same-type multi-selection "benefits" from the hack. Just saying for the sake of completeness / not addressing this now.

Generated at Mon Feb 12 09:08:31 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.