[MGNLUI-3637] SystemLanguagesFieldDefinition should not build options in getter Created: 28/Oct/15 Updated: 15/Apr/16 Resolved: 13/Jan/16 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | security app |
| Affects Version/s: | 5.4.2 |
| Fix Version/s: | 5.4.4 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Mikaël Geljić | Assignee: | Ngoc Nguyenthanh |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | fields | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 3.5d | ||
| Original Estimate: | 2d | ||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Sprint: | Basel 19, Saigon 26 | ||||||||
| Story Points: | 5 | ||||||||
| Description |
|
SystemLanguagesFieldDefinition builds options in getter, using MgnlContext. Making definitions return contextual info (e.g. currentLocale) defeats the purpose of having a single, valid, reliable configuration for all, and must be avoided. It might lead to errors when accessing definitions outside of any Context (as occurred in linked issue).
|
| Comments |
| Comment by Ngoc Nguyenthanh [ 04/Nov/15 ] |
|
I have fixed by:
Due to fix version is 5.4.4 but I have done the ticket when installed version is 5.4.3-SNAPSHOT. So when we do the integration we need to update the version in:
|
| Comment by Evzen Fochr [ 11/Jan/16 ] |
|
Preselected language is not cosistent with previsious version. |
| Comment by Ngoc Nguyenthanh [ 13/Jan/16 ] |
|
SystemLanguagesFieldFactory inherit from SelectFieldFactory |