[MGNLUI-3687] Dialogs show unnecessary scrollbars in some browsers Created: 30/Nov/15 Updated: 09/Feb/17 Resolved: 18/Aug/16 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | dialogs |
| Affects Version/s: | 5.3.11, 5.4.3 |
| Fix Version/s: | 5.3.16, 5.4.9, 5.5 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Christoph Meier | Assignee: | Mikaël Geljić |
| Resolution: | Fixed | Votes: | 1 |
| Labels: | devwl, next, support, ux | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 9d 5.5h | ||
| Original Estimate: | 4d | ||
| Environment: |
Tried on magnolia-enterprise-pro-demo-bundle; windows 7 professional |
||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| Template: |
|
||||||||
| Acceptance criteria: |
Empty
|
||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||
| Date of First Response: | |||||||||
| Sprint: | Saigon 57 | ||||||||
| Story Points: | 8 | ||||||||
| Description |
|
Dialogs show unnecessary scrollbars on Windows 7 Professional (the Magnolia Basel dev windows Laptop; Lenovo) and Mac
|
| Comments |
| Comment by Mikaël Geljić [ 05/Jul/16 ] |
|
On the Mac, it's easy to miss the scrollbar problems, because of the auto-hide scrollbar feature. But it should be disabled prior to investigating this:
|
| Comment by Hieu Nguyen Duc [ 07/Jul/16 ] |
|
What I've seen so far is the v-shell-tabsheet-scroller (I call it scroller) has a redundant space exactly equals the scrollbar width (see the pictures below). Of course the scrollbar width is various on browsers and OS such as 15px on Chrome and 17px on IE. + Switching tabs has an animation that changes tab panel's styles and also affects the children inside e.g scroller. + It seems like the scroller's overflow needs to be controlled together with the transition animation based on the comparison between its max-height and height. + The PR I provide is a way to manually control it. |
| Comment by Hieu Nguyen Duc [ 20/Jul/16 ] |
|
This issue will be resolved with just one small problem left in IE11. |
| Comment by Oanh Thai Hoang [ 22/Jul/16 ] |
|
Fail UI Test: |
| Comment by Mikaël Geljić [ 28/Jul/16 ] |
|
This was re-investigated, yet out of luck so far. We discussed it w/ apchelintcev earlier this week; we concurred that animations play a part in that, that it's currently not trivial to synchronize them against the Vaadin layout phase. We could think about a couple ideas which may affect this in positive ways:
Meanwhile, this is postponed for now. |
| Comment by Aleksandr Pchelintcev [ 28/Jul/16 ] |
|
FWIW, forcing layout upon animation finalisation helps reliably in this situation. ApplicationConnection#forceLayout() It's a costly operation (on the client-side), but maybe we could use it as a w/around in the mean time. WidgetUtil#runWebkitOverflowAutoFix() Unfortunately, so far I didn't manage to make use of it. |
| Comment by Ngoc Nguyenthanh [ 08/Aug/16 ] |
|
I have played around 5.4.x bundle. |
| Comment by Ngoc Nguyenthanh [ 11/Aug/16 ] |
|
As discussed with mgeljic. I'm going to close this ticket and create a follow up |
| Comment by Ngoc Nguyenthanh [ 15/Aug/16 ] |
|
Here is the status of QA
I would move back this ticket to development. |
| Comment by Mikaël Geljić [ 16/Aug/16 ] |
|
Just happened to look into it by chance, while playing around with the permission tool (had similar symptoms). PR seems to cure the issue. |
| Comment by Mikaël Geljić [ 16/Aug/16 ] |
|
Much easier to reproduce with the case from the support ticket, by the way. Attaching such a YAML sample (two tabs, only one short field each), doesn't take much switching tabs to run into it. |