[MGNLUI-3699] JcrNodeAdapter#getJcrItem do not return VersionedNode and VersionedChildNode wrapped. Created: 03/Dec/15  Updated: 14/Jun/16  Resolved: 26/Jan/16

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: 5.4.5

Type: Bug Priority: Neutral
Reporter: Evzen Fochr Assignee: Evzen Fochr
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: 0d
Time Spent: 2d 7h
Original Estimate: Not Specified

Attachments: Text File MGNLUI-3699.patch    
Issue Links:
Relates
relates to MGNLUI-3698 DetailPresenter#cloneFormDefinitionRe... Closed
supersession
supersedes MGNLPN-239 Show version action do not show segme... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Kromeriz 28
Story Points: 2

 Description   

To reproduce: open segments-app, publish the segments, to get versions . 'Show versions' and select one. The traits are missing for the segment.

We need adapter that keep wrapped node that we get from VersionManager for use in transformers later.

https://wiki.magnolia-cms.com/display/DEV/Concept+-+How+to+work+with+wrapped+nodes+in+JcrNodeAdapter



 Comments   
Comment by Roman Kovařík [ 14/Dec/15 ]

Write concept, describe the problem and suggest a solution.

Comment by Evzen Fochr [ 16/Dec/15 ]

https://wiki.magnolia-cms.com/display/DEV/Concept+-+How+to+work+with+wrapped+nodes+in+JcrNodeAdapter

Comment by Jan Haderka [ 19/Jan/16 ]

Before review, let's retry with patch provided by Espen on the concept page. That looks helluva simpler than what is on the branch

Comment by Espen Jervidalo [ 19/Jan/16 ]

I attached a patch along the lines of what we discussed today. Still needs some polishing.

Comment by Jaroslav Simak [ 22/Jan/16 ]

There is one side affect we will need to address - some of the fields in versioned nodes are editable. We should disable save action if we're showing versioned node or make fields read only. efochr could you please create followup ticket?

Comment by Roman Kovařík [ 26/Jan/16 ]

The 'Save changes' button is present also for versions which causes UI tests to fail:
https://jenkins.magnolia-cms.com/job/magnolia-bundle_trunk-with-selenium_profile/lastBuild/#showFailuresLink

Generated at Mon Feb 12 09:09:14 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.