[MGNLUI-3717] BrowserLocation should treat null 'parameter' argument as an empty string Created: 15/Dec/15 Updated: 24/Dec/15 Resolved: 15/Dec/15 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | 5.3.11, 5.4.3 |
| Fix Version/s: | 5.3.12, 5.4.4 |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Aleksandr Pchelintcev | Assignee: | Ngoc Nguyenthanh |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0.5d | ||
| Time Spent: | 0.5d | ||
| Original Estimate: | 1d | ||
| Issue Links: |
|
||||||||||||||||
| Template: |
|
||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||
| Date of First Response: | |||||||||||||||||
| Sprint: | Saigon 24 | ||||||||||||||||
| Story Points: | 1 | ||||||||||||||||
| Description |
|
BrowserLocation takes additional argument parameter besides of typical args like app and sub-app. parameter carries information about the view type which should be initially displayed, item path which should be selected etc. All that information is parsed from parameter, but no null check is performed which leads to silly NPE's. Simple fallback to empty string prevents them. |
| Comments |
| Comment by Ngoc Nguyenthanh [ 22/Dec/15 ] |
|
Here is why it is the cause lead to the issue
|
| Comment by Mikaël Geljić [ 22/Dec/15 ] |
|
At the moment, I cannot reproduce that standalone. Copying parts of the hipchat discussion here, for the sake of completeness:
|
| Comment by Mikaël Geljić [ 22/Dec/15 ] |
|
Still no NPE (besides in the unit test), even without fix from |