[MGNLUI-3735] AbstractCommandsAction should not force params for commands Created: 31/Dec/15 Updated: 11/Mar/21 Resolved: 11/Mar/21 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Neutral |
| Reporter: | Jan Haderka | Assignee: | Unassigned |
| Resolution: | Obsolete | Votes: | 0 |
| Labels: | quickwin, tech-debt | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Attachments: |
|
| Template: |
|
| Patch included: |
Yes
|
| Acceptance criteria: |
Empty
|
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
| Story Points: | 1 |
| Description |
|
Specially since it doesn't provide subclasses w/ any means to set the map itself (it is initialised as unmodifiable collection in onPreExecute() and filled in w/ just the id of item making it pretty useless. Plus not every command requires any parameters in a first place. Attached patch adds null check when building unmodifiable collection to prevent NPE in case onPreExecute() is overwritten, but still doesn't expose map to the subclasses. |