[MGNLUI-374] ContactLinkFieldBuilder should configure its ImageProvider with the config in its subapps workbench definition Created: 07/Dec/12  Updated: 27/Jun/13  Resolved: 27/Jun/13

Status: Closed
Project: Magnolia UI
Component/s: app framework, content app
Affects Version/s: 5.0
Fix Version/s: 5.0

Type: Bug Priority: Critical
Reporter: Christopher Zimmermann Assignee: Unassigned
Resolution: Outdated Votes: 0
Labels: apiteam, content-app, framework, frontend
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
duplicate
is duplicated by MGNLUI-289 ContactLinkFieldBuilder: Injection of... Closed
relation
is related to MGNLUI-371 Page Editor: Cannot edit or add a Con... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:

 Description   

This is a followup task to MGNLUI-370. To fix 370 (where the ImageProvider could not be injected) a new ImageProviderDefinition configuration was hard coded in ContactLinkFieldBuilder. It should not be hard coded, it should be retrieved from the workbench definition of the contacts main sub app.

Resolving this issue may be as simple as retrieving the configuration information in a clean way. But I was not able to see an obvious way for a LinkFieldBuilder to get workbench config of it's sub app. So the solution could be to change the framework such that this information is available.

One lead is that perhaps the ContactLinkFieldDefinition or the LinkFieldDefinition could be extended to store the workbench definition.

Or maybe the workbench definition does not need to be added, maybe it would be enough to make the ContactLinkFieldDefinition include an ImageProviderDefinition. More evaluation needed.



 Comments   
Comment by Christopher Zimmermann [ 07/Dec/12 ]

This is follow-up ticket to 371

Comment by Tobias Mattsson [ 14/Feb/13 ]

ImageProvider should not be configured inside the workbench definition.

Generated at Mon Feb 12 08:36:15 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.