[MGNLUI-3752] In-line edited property is not always selected after saving changes Created: 19/Jan/16  Updated: 21/Mar/16  Resolved: 18/Mar/16

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.4.4
Fix Version/s: 5.4.6

Type: Bug Priority: Major
Reporter: Andreas Weder Assignee: Ngoc Nguyenthanh
Resolution: Fixed Votes: 0
Labels: is-time-consuming, pain-point, ux, working-with-items
Remaining Estimate: 0.75d
Time Spent: 4.25d
Original Estimate: 5d
Environment:

5.4.4 EE Pro in Firefox 43.0.4 and Safari 9.0.2 on Mac OS X 10.11.2.
Also emptied cache and tried browser restarts.


Attachments: PNG File 1 Mouse hovers over version.png     PNG File 2 Double-click to in-line edit to versions.png     PNG File 3 Hit return to save- item is NOT selected.png    
Issue Links:
dependency
is depended upon by MGNLCE-30 Cover MGNLUI-3752 in UI Tests Closed
supersession
supersedes MGNLUI-3665 Quick-edited item sometimes appears N... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Epic Link: UX pain points 2018
Sprint: Saigon 35
Story Points: 8

 Description   

This should have been fixed by MGNLUI-3665, but I've just happened to stumble over a case with the just released 5.4.4 that shows that this isn't fully fixed yet.

To reproduce:

  • Open the Configuration app.
  • If you double-click on a folder or visible property to in-line edit it without selecting it first, the item is selected after saving the change. So well, so good.
  • But if I open "modules/google-analytics", then double click on "version", then change the name to "versions" using in-line editing and without selecting it first, the property is NOT selected after saving the changes.

Acceptance criteria:

  • In the second case, the item should be both modified to "versions", but also be selected and visible (in view). All previously selected items should get deselected.


 Comments   
Comment by Andreas Weder [ 20/Jan/16 ]

Raised this to critical as it's one big topic with MGNLUI-3665, MGNLUI-3467, MGNLUI-2927, MGNLUI-2919, MGNLDAM-631 that should be finalized together - we only partially fixed this for 5.4.4, so it can't be announced as fixed.

Comment by Federico Grilli [ 27/Jan/16 ]

Unfortunately I wasn't able to pinpoint the cause for this behaviour in the allowed timeframe. Admittedly though, I only looked at the server-side part of this. The "odd" thing about the issue is that the same action is used both for saving nodes (which keep selection after being edited) and properties (which lose selection). The action is info.magnolia.ui.contentapp.browser.action.SaveItemPropertyAction.execute() and the main difference there seems to be that in the node case the method returns right after saving, whereas in the property case a SelectionChangedEvent is triggered . However, even commenting out the event triggering part didn't help. Also forcing the selection of the item after the saving operation went through successfully did not work.

Comment by Ngoc Nguyenthanh [ 10/Mar/16 ]

What happened?

  • TreePresenter fire an event onItemEdited to execute an action saveItemProperty which defined in the Configuration app. The implementation class is SaveItemPropertyAction
  • When the edited property is saved, SaveItemPropertyAction will fire an event SelectionChangedEvent under SubAppEventBus
  • The code to handle refresh of tree and selected item is in BrowserPresenter with AdmincentralEventBus handler which is register to listen ContentChangedEvent

What's solution?

  • SaveItemPropertyAction should fire an event ContentChangedEvent when it save a property as its name meaning.
  • In order to refresh the tree and selected items the event should be fired via AdmincentralEventBus

Actions

  • Correct the behavior in info.magnolia.ui.contentapp.browser.action.SaveItemPropertyAction
  • Cover by ui-tests
Generated at Mon Feb 12 09:09:44 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.