[MGNLUI-3758] Remove usages of AbstractFieldFactory's deprecated constructor Created: 27/Jan/16  Updated: 09/Feb/17  Resolved: 26/May/16

Status: Closed
Project: Magnolia UI
Component/s: content app, forms, framework, security app
Affects Version/s: 5.4.4
Fix Version/s: 5.4.7, 5.5

Type: Task Priority: Neutral
Reporter: Mikaël Geljić Assignee: Hieu Nguyen Duc
Resolution: Fixed Votes: 0
Labels: deprecated, tech-debt
Remaining Estimate: 0d
Time Spent: 8d 3h
Original Estimate: 3d

Issue Links:
Cloners
is cloned by MGNLDAM-634 CLONE - Remove usages of AbstractFiel... Closed
is cloned by PAGES-53 CLONE - Remove usages of AbstractFiel... Closed
relation
is related to MGNLUI-3489 Support field default value for local... Closed
supersession
is superseded by MGNLUI-3887 Generalize some usages of concrete Co... Closed
Template:
Acceptance criteria:
Empty
Task DoR:
Empty
Release notes required:
Yes
Date of First Response:
Epic Link: Form field attributes handling
Sprint: Saigon 45
Story Points: 5

 Description   

As part of MGNLUI-3508 sub-tasks, AbstractFieldFactory's old two-arg constructor was deprecated to inject UiContext and I18nAuthoringSupport along the way.

Implementing classes have not been adapted.
Instead an ugly workaround set the UiContext via static Components upon #setCP, which is effing annoying to keep tests simple without a whole bunch of ComponentTestUtil registrations to the rescue.



 Comments   
Comment by Mikaël Geljić [ 14/Apr/16 ]

Goal is to move forward with the easy parts, maybe it's not so trivial to get rid of the dubious injections of uiContext and i18nAuthoringSupport... needs thorough QA anyways.

Comment by Ngoc Nguyenthanh [ 22/Apr/16 ]

We've tickets to update constructors for DAM & Pages already.
Here is list of classes need to be updated also:

info.magnolia.amazon.s3.ui.field.StatusFieldFactory
info.magnolia.konakart.integration.app.detail.field.KonaKartAssetImageFieldFactory
info.magnolia.damext.liberated.app.field.AssetLinkFieldFactory
info.magnolia.commercetools.integration.app.detail.fields.CategoriesListFieldFactory
info.magnolia.commercetools.integration.app.detail.fields.CommerceToolsImageFieldFactory
info.magnolia.commercetools.integration.app.detail.fields.PricesListFieldFactory
info.magnolia.commercetools.integration.app.detail.fields.VariantsListFieldFactory
info.magnolia.marketingtags.app.field.factory.PageLinkFieldFactory
info.magnolia.module.backup.app.field.factory.ExistingTasksFieldFactory
info.magnolia.module.dependencies.field.DependenciesFieldFactory
info.magnolia.module.googlesitemap.app.field.TemplateStaticFieldFactory
info.magnolia.module.groovy.field.factory.ConsoleOutputFieldFactory
info.magnolia.module.rssaggregator.field.factory.RunEveryRSSImportButtonFieldFactory
info.magnolia.module.rssaggregator.field.factory.RunRSSImportButtonFieldFactory
info.magnolia.personalization.ui.TraitAggregatorFieldFactory
info.magnolia.personalization.ui.traitchooser.TraitChooserFieldFactory
info.magnolia.personalization.preview.ui.field.personaswitcher.PersonaSwitcherFieldFactory
info.magnolia.personalization.date.system.DateTraitFieldFactory
info.magnolia.asset.app.field.factory.AssetMetadataFieldFactory - websphere
info.magnolia.wcs.integration.app.field.factory.WcsImageFieldFactory
info.magnolia.wcs.integration.app.field.factory.WcsLinkFieldFactory
Generated at Mon Feb 12 09:09:47 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.