[MGNLUI-3798] Task count no longer updated in Pulse Created: 04/Mar/16 Updated: 29/Sep/16 Resolved: 10/Mar/16 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | pulse |
| Affects Version/s: | 5.4.4, 5.4.5 |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Critical |
| Reporter: | Andreas Weder | Assignee: | Oanh Thai Hoang |
| Resolution: | Duplicate | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 3d 0.5h | ||
| Time Spent: | 1d 7.5h | ||
| Original Estimate: | 5d | ||
| Environment: |
magnolia-enterprise-pro-demo-bundle-5.4.5-20160303.205953-78-tomcat-bundle.tar.gz |
||
| Attachments: |
|
||||||||||||||||||||||||
| Issue Links: |
|
||||||||||||||||||||||||
| Template: |
|
||||||||||||||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||||||||||||||
| Bug DoR: |
[ ]*
Steps to reproduce, expected, and actual results filled
[ ]*
Affected version filled
|
||||||||||||||||||||||||
| Date of First Response: | |||||||||||||||||||||||||
| Sprint: | Saigon 34 | ||||||||||||||||||||||||
| Story Points: | 8 | ||||||||||||||||||||||||
| Description |
|
I've noticed during the preparation for a demo that the badges shown on the filter tabs under "Task" in Pulse are no longer updated, when a task switches state. I didn't check if this is also true for "Messages". To reproduce: I've created two publishing requests. When I log in as "peter" I get a task count of 2 under "NEW". That number sticks when I assign the tasks to me: 2 is still shown under "NEW", and "ASSIGNED" shows no badge. When I approve & publish the requests, the 2 still shows under "NEW". I've noticed this in 5.4.4 first, but was able to verify it with a 5.4.5 snapshot build taken shortly before release (see Environment for details), which is why I assume that the bug will also be there in 5.4.5 final. |
| Comments |
| Comment by Oanh Thai Hoang [ 08/Mar/16 ] |
|
Root cause: info.magnolia.ui.admincentral.shellapp.pulse.task.TasksListPresenter hasn't call function updateView to update status of badges after navigation or any event of tasks (such as add, fail, claim..) Solution: Should call function updateView inside function refreshData that has been called in every task handler executions.
private void refreshData() {
listener.updatePulseCounter();
container.refresh();
updateView();
}
Hi, mgeljic, apchelintcev . Could you please have a look at my PR. Thanks in advance. |
| Comment by Mikaël Geljić [ 10/Mar/16 ] |
|
Thanks for digging the duplicate, fix was right too |