[MGNLUI-3800]  "detail" subapp is hardcoded in info.magnolia.ui.contentapp.browser.action.ShowVersionsAction#getLocation method Created: 07/Mar/16  Updated: 07/Apr/16  Resolved: 04/Apr/16

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: Neutral
Reporter: Ervin Vystup Assignee: Oanh Thai Hoang
Resolution: Won't Do Votes: 0
Labels: support
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
relation
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Saigon 38
Story Points: 3

 Description   

Hardcoded "detail" subapp is used in info.magnolia.ui.contentapp.browser.action.ShowVersionsAction#getLocation method



 Comments   
Comment by Mikaël Geljić [ 21/Mar/16 ]

Just writing down our impression with Jan last week: naming the DetailSubApp "detail" is kind of an implicit convention (same as BrowserSubApp is typically named browser). It's unclear what else would possibly break when using something else.

Besides, here for the example at hand (see linked ticket), it seemed there was an additional "edit" subapp; couple thoughts there:

  • first, showing a version should not enable to edit it
  • then FYI DetailSubApp/DetailLocation support viewTypes, either VIEW or EDIT too
Comment by Mikaël Geljić [ 04/Apr/16 ]

Hi evystup,

While I agree that, on technical grounds, this enforced naming is debatable, I believe it's not critical for this current case (maybe there's additional insight in my comment above which helps).

As for the root-path problem, it's currently being addressed in MGNLUI-3799. When it's done, I expect content apps with specific root-path to be compliant with Magnolia versioning.

Feel free to speak up if you have a compelling case where this is too limiting. If so, we'll probably create a proper story for that, otherwise, I'm closing this ticket for now.

Generated at Mon Feb 12 09:10:12 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.