[MGNLUI-3810] Pulse hides new tasks created by current user Created: 14/Mar/16  Updated: 26/Aug/16  Resolved: 11/Apr/16

Status: Closed
Project: Magnolia UI
Component/s: None
Affects Version/s: 5.3.13, 5.3.14, 5.4.4
Fix Version/s: 5.3.15, 5.4.6

Type: Bug Priority: Major
Reporter: Zdenek Skodik Assignee: Oanh Thai Hoang
Resolution: Fixed Votes: 0
Labels: support
Remaining Estimate: 0d
Time Spent: 4d 3h
Original Estimate: 2d

Attachments: PNG File Screen Shot 2016-03-22 at 13.03.31.png     PNG File Screen Shot 2016-03-22 at 13.08.37.png     PNG File Screen Shot 2016-03-22 at 13.09.18.png     PNG File Screen Shot 2016-03-22 at 13.14.07.png     PNG File eric-pulse-case1.png     PNG File eric-pulse-case2.png     PNG File eric2-pulse-cae2.png     PNG File eric2-pulse-case1.png     PNG File message-app-send-demo-project-editors.png     PNG File message-app-send-editors.png    
Issue Links:
Relates
dependency
depends upon MAGNOLIA-6615 UserManager#getUsersWithGroup(groupNa... Closed
relation
is related to MGNLLDAP-95 LDAP paging support Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Bug DoR:
[ ]* Steps to reproduce, expected, and actual results filled
[ ]* Affected version filled
Date of First Response:
Sprint: Saigon 38
Story Points: 3

 Description   

To reproduce with STK demo:

  • assign demo-project-editors role to peter
  • become peter
  • publish /demo-project
  • you should find the pulse badge not increased and no new task visible in there. It gets refreshed only manually, e.g. if you forth/back switch tabs within Pulse.

Update:
The problem is that the LocalTaskDispatcherManager#getAllRecipients doesn't seem to resolve groups transitively.
So peter is member of 'demo-project-publisher' and transitively member of 'publisher' group: He should receive the task-event.
The reason why this works in the new demo is because the group was set up wrong in the first place. 'travel-demo-publisher' is not part of 'publisher' group but the publish-task is assigned to both groups.

The transitive group-member is working correctly when it's not triggered by the event, so it's implemented correctly there. This might help: TasksStoreImpl#findPendingTasksByUser or GroupManager#getAllGroups(java.lang.String)

See attached screenshots.



 Comments   
Comment by Oanh Thai Hoang [ 17/Mar/16 ]

This bug happen for every enterprise bundle installed magnolia-demo-project module. The bug doesn't happen with travel-demo-publishers group of magnolia-travel-demo module.

Root cause: Missing workflow permission for demo-project-publishers group in workflow-jbpm module.

Solution:

  • Add task to set new property demo-project-publishers in "/modules/workflow-jbpm/tasks/publish/groups" in DemoProjectVersionHandler class.
  • Versions: 2.8.11-SNAPSHOT and 2.9.4-SNAPSHOT

For reference code, we can add the similar code of SetupDemoRolesAndGroupsTask class in magnolia-travel-demo module

Following is the code that need to put to DemoProjectVersionHandler class

    public static final String DEMO_PROJECT_PUBLISHERS_GROUP = "demo-project-publishers";
    public static final String WORKFLOW_JBPM_MODULE = "workflow-jbpm";
    public static final String WORKFLOW_JBPM_PUBLISH_GROUPS = "/modules/workflow-jbpm/tasks/publish/groups";

...........
 register(DeltaBuilder.update("2.9.4", "")
    .addTask(new IsModuleInstalledOrRegistered("If workflow-jbpm module is installed, add workflow permissions for " + DEMO_PROJECT_PUBLISHERS_GROUP, WORKFLOW_JBPM_MODULE, new NewPropertyTask("", WORKFLOW_JBPM_PUBLISH_GROUPS, DEMO_PROJECT_PUBLISHERS_GROUP, DEMO_PROJECT_PUBLISHERS_GROUP)));
Comment by Oanh Thai Hoang [ 29/Mar/16 ]

Stop progress because it depends on MAGNOLIA-6615

Comment by Oanh Thai Hoang [ 04/Apr/16 ]

It not only depend upon MAGNOLIA-6615, but MAGNOLIA-6615 actually also fixes it. So just wait for 6615 is integrated and need one guy to run QA to confirm

Comment by Mikaël Geljić [ 11/Apr/16 ]

Confirmed: fixed in depending ticket MAGNOLIA-6615, no code change in this ticket; closing.

Generated at Mon Feb 12 09:10:18 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.