[MGNLUI-3820] Provide task for adding delegate action, use task in security app Created: 23/Mar/16  Updated: 09/Aug/16  Resolved: 06/Jun/16

Status: Closed
Project: Magnolia UI
Component/s: content app
Affects Version/s: 5.4.4
Fix Version/s: 5.4.8

Type: Improvement Priority: Neutral
Reporter: Antonín Juran Assignee: Jaroslav Simak
Resolution: Fixed Votes: 1
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MGNLUI-3971 Wrong update version used for task "d... Closed
relates to MGNLUI-3837 Action to expand folders Closed
dependency
depends upon MGNLUI-3774 Provide action which delegates to ano... Closed
depends upon MGNLUI-3821 Provide API for collapse node Closed
duplicate
duplicates MGNLUI-1411 Default action should be configureabl... Closed
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:
Sprint: Kromeriz 47
Story Points: 5

 Description   

Use DelegateByNodeTypeAction implemented in MGNLUI-3774 for the default action.

Default use case

For apps with hierarchical data sets supporting folders, we add the following default actions:

  • For folders: toggle the open state of the folder. So, if closed, we open the folder; if opened, we close the folder.
  • For items: use the current default action, i.e. we open the details sub app (aka the edit dialog) for the item.

Apps in scope of this ticket are: Assets, Contacts, Categorization, Security, Tours, Segments. For all other apps, we don't do anything.



 Comments   
Comment by Mikaël Geljić [ 13/Apr/16 ]

re: toggling folders, I'm not sure yet if I'd go with the delegating action *everywhere*:

  • e.g. for some time I thought an easy fix would be to move the defaultAction to individual ActionbarSectionDefinitions, but even then mapping content types would not be perfect
  • I'd rather declare this on a content type level (ideally not just JCR), and give the workbench a better notion of "folders".
    • Then content-views would be capable of handling the toggling at a lower (view) level.
    • Generally we might think about more interactions triggering more different actions too (single-click rename too?)
  • Config is already spoiled everywhere, we should eventually just simplify it
Comment by Jan Haderka [ 17/May/16 ]

Definitively not everywhere. Only 6 selected apps mentioned in the description.
And yes, we need eventually revisit hooks for action triggering and generalize them better, but I don't see that happening any time soon all things considered.

Comment by Christopher Zimmermann [ 03/Aug/16 ]

In my brief tests - folders only open on a double click, they do not "toggle", because they do not close on a double click. Also only the security app exhibits this behaviour - not the other tickets. Please either reopen - or update the description and summary to reflect the reality, and possibly create a follow up ticket. Or was their a conccious decision not to do this on the other apps?

Generated at Mon Feb 12 09:10:24 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.