[MGNLUI-3837] Action to expand folders Created: 04/Apr/16 Updated: 25/May/16 Resolved: 26/Apr/16 |
|
| Status: | Closed |
| Project: | Magnolia UI |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | 5.4.6 |
| Type: | Improvement | Priority: | Neutral |
| Reporter: | Jan Haderka | Assignee: | Antonín Juran |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | 0d | ||
| Time Spent: | 35m | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Template: |
|
||||||||||||
| Acceptance criteria: |
Empty
|
||||||||||||
| Task DoD: |
[ ]*
Doc/release notes changes? Comment present?
[ ]*
Downstream builds green?
[ ]*
Solution information and context easily available?
[ ]*
Tests
[ ]*
FixVersion filled and not yet released
[ ] 
Architecture Decision Record (ADR)
|
||||||||||||
| Date of First Response: | |||||||||||||
| Sprint: | Kromeriz 41 | ||||||||||||
| Story Points: | 3 | ||||||||||||
| Comments |
| Comment by Mikaël Geljić [ 12/Apr/16 ] |
|
Maybe a little context, description and use-case could help there Anyway here's my take on the two current proposals:
Also worth noting that "making the UI, presenters or views easily react to the outcome of actions" is yet another pain point which has never been fundamentally addressed (besides the super-limited callbacks carrying zero useful information). Nothing we'd like to stick with for too long. |
| Comment by Antonín Juran [ 13/Apr/16 ] |
|
Reason for implementation of the action (ExpandNodeAction) is request for providing defaultAction by node type (see |
| Comment by Mikaël Geljić [ 13/Apr/16 ] |
|
Ok thanks for the explanation, re: PR #105 there should be only one instance of WorkbenchPresenter throughout the whole subapp, maybe we need an extra singleton declaration there? re: toggling folders, I'm not sure yet if I'd go with the delegating action *everywhere*:
I'll copy my notes above to For this ticket I can totally live with this action, it gives the possibility at least. |
| Comment by Antonín Juran [ 15/Apr/16 ] |
|
Thanks for your comment, |
| Comment by Mikaël Geljić [ 15/Apr/16 ] |
|
|
| Comment by Antonín Juran [ 18/Apr/16 ] |
|
Use firing of ContentChangedEvent in ExpandNodeAction and its existing handling in BrowserPresenter. |