[MGNLUI-3842] Hide tab title in case dialog has only one tab Created: 07/Apr/16  Updated: 11/Mar/21  Resolved: 11/Mar/21

Status: Closed
Project: Magnolia UI
Component/s: dialogs
Affects Version/s: 5.4.5
Fix Version/s: None

Type: Improvement Priority: Neutral
Reporter: Ngoc Nguyenthanh Assignee: Unassigned
Resolution: Obsolete Votes: 1
Labels: dialog, ux
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: PNG File single-tab-dialog.png    
Template:
Acceptance criteria:
Empty
Task DoD:
[ ]* Doc/release notes changes? Comment present?
[ ]* Downstream builds green?
[ ]* Solution information and context easily available?
[ ]* Tests
[ ]* FixVersion filled and not yet released
[ ]  Architecture Decision Record (ADR)
Date of First Response:

 Description   

In case of a dialog has only single tab. The dialog title is enough. We don't need to display tab's title in this case.



 Comments   
Comment by Mikaël Geljić [ 07/Apr/16 ]

maybe only if that tab title is empty?

Comment by Christopher Zimmermann [ 07/Apr/16 ]

yes! - I have thought this a million times, but never wrote it down in a ticket.

Often you even struggle to come up with a name for a tab because it is redundant. Hence we have many tabs labled "Main", but they should not be shown.

I see the point of Mikael's comment. But maybe we should review existing dialogs to see if that check is even necessary. My hunch is that it is not and we would have a cleaner UI if we removed all tab labels if there is only one tab.

Comment by Andreas Weder [ 08/Apr/16 ]

Definitely. It was never meant to work that way, but that we only show tabs when tabs are necessary.

I vaguely remember we explicitly hid that tab in one or two cases, but actually, that doesn't matter - we should always only show tabs if there's at least two defined.

Please also quickly check for duplicate tickets - I remember there was one some time ago, but it may have been closed recently during a cleanup.

Comment by Christopher Zimmermann [ 18/Apr/16 ]

I would remove the space for the tab as well.

  • Preserves space.
  • Makes it clear that there is no tab - not just that there is no label for the tab.

@weder Do you agree?

Generated at Mon Feb 12 09:10:37 CET 2024 using Jira 9.4.2#940002-sha1:46d1a51de284217efdcb32434eab47a99af2938b.